* [PATCH] staging: comedi: drivers.c: fix checkpatch code style issue
@ 2014-08-06 0:53 Dzonatans Melgalvis
2014-08-06 2:35 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Dzonatans Melgalvis @ 2014-08-06 0:53 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Dzonatans Melgalvis
Fixing checkpatch warning - blank line missing after declaration.
Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com>
---
drivers/staging/comedi/drivers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 9ada130..00e01d0 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -440,6 +440,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
static void comedi_report_boards(struct comedi_driver *driv)
{
unsigned int i;
+
const char *const *name_ptr;
pr_info("comedi: valid board names for %s driver are:\n",
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: comedi: drivers.c: fix checkpatch code style issue
2014-08-06 0:53 [PATCH] staging: comedi: drivers.c: fix checkpatch code style issue Dzonatans Melgalvis
@ 2014-08-06 2:35 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-08-06 2:35 UTC (permalink / raw)
To: Dzonatans Melgalvis; +Cc: gregkh, devel, linux-kernel
On Wed, 2014-08-06 at 03:53 +0300, Dzonatans Melgalvis wrote:
> Fixing checkpatch warning - blank line missing after declaration.
[]
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
[]
> @@ -440,6 +440,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
> static void comedi_report_boards(struct comedi_driver *driv)
> {
> unsigned int i;
> +
> const char *const *name_ptr;
>
> pr_info("comedi: valid board names for %s driver are:\n",
This is also a false positive from an old version
of checkpatch.
For all messages produced by brainless tools,
please use your skill, experience, and taste and
look at what is being suggested and see if it's
right before sending patches based on the tools
suggestions.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-06 2:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 0:53 [PATCH] staging: comedi: drivers.c: fix checkpatch code style issue Dzonatans Melgalvis
2014-08-06 2:35 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®