* [PATCH] ASoC: wm8994: register irq handler for mic1 detect
@ 2014-08-12 11:43 Nikesh Oswal
2014-08-12 11:48 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Nikesh Oswal @ 2014-08-12 11:43 UTC (permalink / raw)
To: broonie, lgirdwood; +Cc: perex, tiwai, alsa-devel, linux-kernel, patches
Signed-off-by: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8994.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 247b390..24bcbe3 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -4099,6 +4099,15 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec)
dev_warn(codec->dev,
"Failed to request Mic1 detect IRQ: %d\n",
ret);
+ } else {
+ ret = wm8994_request_irq(wm8994->wm8994,
+ WM8994_IRQ_MIC1_DET,
+ wm8994_mic_irq, "Mic 1 detect",
+ wm8994);
+ if (ret != 0)
+ dev_warn(codec->dev,
+ "Failed to request Mic1 detect IRQ: %d\n",
+ ret);
}
ret = wm8994_request_irq(wm8994->wm8994,
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: wm8994: register irq handler for mic1 detect
2014-08-12 11:43 [PATCH] ASoC: wm8994: register irq handler for mic1 detect Nikesh Oswal
@ 2014-08-12 11:48 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-08-12 11:48 UTC (permalink / raw)
To: Nikesh Oswal; +Cc: lgirdwood, perex, tiwai, alsa-devel, linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Tue, Aug 12, 2014 at 12:43:49PM +0100, Nikesh Oswal wrote:
> --- a/sound/soc/codecs/wm8994.c
> +++ b/sound/soc/codecs/wm8994.c
> @@ -4099,6 +4099,15 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec)
> dev_warn(codec->dev,
> "Failed to request Mic1 detect IRQ: %d\n",
> ret);
> + } else {
> + ret = wm8994_request_irq(wm8994->wm8994,
> + WM8994_IRQ_MIC1_DET,
> + wm8994_mic_irq, "Mic 1 detect",
> + wm8994);
> + if (ret != 0)
> + dev_warn(codec->dev,
> + "Failed to request Mic1 detect IRQ: %d\n",
> + ret);
This need a better changelog and possibly some editing of the code to
make it clearer. According to the above diff we're in the else case for
an if statement where the true path also requests the same interrupt (or
at least something with the same text reported in the error message).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-12 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-12 11:43 [PATCH] ASoC: wm8994: register irq handler for mic1 detect Nikesh Oswal
2014-08-12 11:48 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®