From: "Radim Krčmář" <rkrcmar@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Gleb Natapov <gleb@kernel.org>,
Raghavendra KT <raghavendra.kt@linux.vnet.ibm.com>,
Vinod Chegu <chegu_vinod@hp.com>,
Hui-Zhi Zhao <hui-zhi.zhao@hp.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Lisa Mitchell <lisa.mitchell@hp.com>
Subject: [PATCH v3 7/7] KVM: VMX: optimize ple_window updates to VMCS
Date: Thu, 21 Aug 2014 18:08:11 +0200 [thread overview]
Message-ID: <1408637291-18533-8-git-send-email-rkrcmar@redhat.com> (raw)
In-Reply-To: <1408637291-18533-1-git-send-email-rkrcmar@redhat.com>
ple_window is preserved in VMCS, so can write it only after a change.
Do this by keeping a dirty bit.
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
arch/x86/kvm/vmx.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 1318232..f32415b 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -510,6 +510,7 @@ struct vcpu_vmx {
/* Dynamic PLE window. */
int ple_window;
+ bool ple_window_dirty;
};
enum segment_cache_field {
@@ -4426,6 +4427,7 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx)
vmcs_write64(POSTED_INTR_DESC_ADDR, __pa((&vmx->pi_desc)));
}
+ vmx->ple_window_dirty = ple_gap;
if (ple_gap) {
vmcs_write32(PLE_GAP, ple_gap);
vmx->ple_window = ple_window;
@@ -5741,6 +5743,9 @@ static void grow_ple_window(struct kvm_vcpu *vcpu)
vmx->ple_window = __grow_ple_window(old);
} while (read_seqretry(&ple_window_seqlock, seq));
+ if (vmx->ple_window != old)
+ vmx->ple_window_dirty = true;
+
trace_kvm_ple_window_grow(vcpu->vcpu_id, vmx->ple_window, old);
}
@@ -5756,6 +5761,9 @@ static void shrink_ple_window(struct kvm_vcpu *vcpu)
ple_window);
} while (read_seqretry(&ple_window_seqlock, seq));
+ if (vmx->ple_window != old)
+ vmx->ple_window_dirty = true;
+
trace_kvm_ple_window_shrink(vcpu->vcpu_id, vmx->ple_window, old);
}
@@ -7505,8 +7513,10 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
if (vmx->emulation_required)
return;
- if (ple_gap)
+ if (vmx->ple_window_dirty) {
+ vmx->ple_window_dirty = false;
vmcs_write32(PLE_WINDOW, vmx->ple_window);
+ }
if (vmx->nested.sync_shadow_vmcs) {
copy_vmcs12_to_shadow(vmx);
--
2.1.0
next prev parent reply other threads:[~2014-08-21 16:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 16:08 [PATCH v3 0/7] Dynamic Pause Loop Exiting window Radim Krčmář
2014-08-21 16:08 ` [PATCH v3 1/7] KVM: add kvm_arch_sched_in Radim Krčmář
2014-08-21 18:49 ` Raghavendra K T
2014-08-21 20:31 ` Radim Krčmář
2014-08-21 21:12 ` Paolo Bonzini
2014-08-21 16:08 ` [PATCH v3 2/7] KVM: x86: introduce sched_in to kvm_x86_ops Radim Krčmář
2014-08-21 18:50 ` Raghavendra K T
2014-08-21 16:08 ` [PATCH v3 3/7] KVM: VMX: make PLE window per-VCPU Radim Krčmář
2014-08-21 18:52 ` Raghavendra K T
2014-08-21 16:08 ` [PATCH v3 4/7] KVM: VMX: dynamise PLE window Radim Krčmář
2014-08-21 19:10 ` Raghavendra K T
2014-08-21 20:31 ` Paolo Bonzini
2014-08-21 20:59 ` Radim Krčmář
2014-08-21 16:08 ` [PATCH v3 5/7] KVM: trace kvm_ple_window grow/shrink Radim Krčmář
2014-08-25 13:53 ` Sabrina Dubroca
2014-08-25 14:32 ` Radim Krčmář
2014-08-25 14:44 ` Paolo Bonzini
2014-08-21 16:08 ` [PATCH v3 6/7] KVM: VMX: runtime knobs for dynamic PLE window Radim Krčmář
2014-08-21 19:17 ` Raghavendra K T
2014-08-21 21:03 ` Radim Krčmář
2014-08-21 16:08 ` Radim Krčmář [this message]
2014-08-21 19:18 ` [PATCH v3 7/7] KVM: VMX: optimize ple_window updates to VMCS Raghavendra K T
2014-08-21 16:30 ` [PATCH v3 0/7] Dynamic Pause Loop Exiting window Paolo Bonzini
2014-08-21 16:50 ` Radim Krčmář
2014-08-21 16:53 ` Paolo Bonzini
2014-08-22 4:45 ` Wanpeng Li
2014-08-25 15:11 ` Radim Krčmář
2014-08-21 17:03 ` Raghavendra K T
2014-08-21 18:40 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408637291-18533-8-git-send-email-rkrcmar@redhat.com \
--to=rkrcmar@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=chegu_vinod@hp.com \
--cc=gleb@kernel.org \
--cc=hui-zhi.zhao@hp.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa.mitchell@hp.com \
--cc=pbonzini@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®