* [PATCH] regulator: RK808: Fix uninitialized value
@ 2014-08-22 0:54 Doug Anderson
2014-08-22 2:19 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Doug Anderson @ 2014-08-22 0:54 UTC (permalink / raw)
To: Mark Brown
Cc: Sonny Rao, Heiko Stuebner, Addy Ke, Chris Zhong, Kever Yang,
linux-arm-kernel, Doug Anderson, lgirdwood, linux-kernel
The RK808 regulator driver was putting its config on the stack but not
initting it. That means that you got a semi-random config. Fix this.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
drivers/regulator/rk808-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index 94753fd..4d5041c 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -334,7 +334,7 @@ static int rk808_regulator_probe(struct platform_device *pdev)
{
struct rk808 *rk808 = dev_get_drvdata(pdev->dev.parent);
struct rk808_board *pdata;
- struct regulator_config config;
+ struct regulator_config config = {};
struct regulator_dev *rk808_rdev;
struct regulator_init_data *reg_data;
int i = 0;
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] regulator: RK808: Fix uninitialized value
2014-08-22 0:54 [PATCH] regulator: RK808: Fix uninitialized value Doug Anderson
@ 2014-08-22 2:19 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-08-22 2:19 UTC (permalink / raw)
To: Doug Anderson
Cc: Sonny Rao, Heiko Stuebner, Addy Ke, Chris Zhong, Kever Yang,
linux-arm-kernel, lgirdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
On Thu, Aug 21, 2014 at 05:54:55PM -0700, Doug Anderson wrote:
> The RK808 regulator driver was putting its config on the stack but not
> initting it. That means that you got a semi-random config. Fix this.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-22 2:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 0:54 [PATCH] regulator: RK808: Fix uninitialized value Doug Anderson
2014-08-22 2:19 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®