* [PATCH] socklnd: Code style fix (eudyptula challenge task 10)
@ 2014-08-22 20:08 Marco Cyriacks
2014-08-22 20:08 ` [PATCH] socklnd: Remove static initialization to NULL or 0 Marco Cyriacks
0 siblings, 1 reply; 2+ messages in thread
From: Marco Cyriacks @ 2014-08-22 20:08 UTC (permalink / raw)
To: gregkh; +Cc: bergwolf, devel, linux-kernel, Marco Cyriacks
Hi,
I'm currently working on the eudyptula challenge and this is my first
"kernel contribution" to pass task 10 of the challenge.
The task was to fix one coding style error of a file in the drivers
staging area.
This patch was prepared on top of next-20140822. Please consider it
for inclusion.
Best regards,
Marco
Marco Cyriacks (1):
socklnd: Remove static initialization to NULL or 0
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] socklnd: Remove static initialization to NULL or 0
2014-08-22 20:08 [PATCH] socklnd: Code style fix (eudyptula challenge task 10) Marco Cyriacks
@ 2014-08-22 20:08 ` Marco Cyriacks
0 siblings, 0 replies; 2+ messages in thread
From: Marco Cyriacks @ 2014-08-22 20:08 UTC (permalink / raw)
To: gregkh; +Cc: bergwolf, devel, linux-kernel, Marco Cyriacks
This patch fixes the following coding style issue:
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Marco Cyriacks <marco@cyriacks.net>
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
index 54c0019..66d78c9 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
@@ -33,7 +33,7 @@ static int peer_credits = 8;
module_param(peer_credits, int, 0444);
MODULE_PARM_DESC(peer_credits, "# concurrent sends to 1 peer");
-static int peer_buffer_credits = 0;
+static int peer_buffer_credits;
module_param(peer_buffer_credits, int, 0444);
MODULE_PARM_DESC(peer_buffer_credits, "# per-peer router buffer credits");
@@ -85,7 +85,7 @@ static int rx_buffer_size = DEFAULT_BUFFER_SIZE;
module_param(rx_buffer_size, int, 0644);
MODULE_PARM_DESC(rx_buffer_size, "socket rx buffer size (0 for system default)");
-static int nagle = 0;
+static int nagle;
module_param(nagle, int, 0644);
MODULE_PARM_DESC(nagle, "enable NAGLE?");
@@ -110,11 +110,11 @@ static int keepalive_intvl = 5;
module_param(keepalive_intvl, int, 0644);
MODULE_PARM_DESC(keepalive_intvl, "seconds between probes");
-static int enable_csum = 0;
+static int enable_csum;
module_param(enable_csum, int, 0644);
MODULE_PARM_DESC(enable_csum, "enable check sum");
-static int inject_csum_error = 0;
+static int inject_csum_error;
module_param(inject_csum_error, int, 0644);
MODULE_PARM_DESC(inject_csum_error, "set non-zero to inject a checksum error");
@@ -126,7 +126,7 @@ static unsigned int zc_min_payload = (16 << 10);
module_param(zc_min_payload, int, 0644);
MODULE_PARM_DESC(zc_min_payload, "minimum payload size to zero copy");
-static unsigned int zc_recv = 0;
+static unsigned int zc_recv;
module_param(zc_recv, int, 0644);
MODULE_PARM_DESC(zc_recv, "enable ZC recv for Chelsio driver");
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-22 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 20:08 [PATCH] socklnd: Code style fix (eudyptula challenge task 10) Marco Cyriacks
2014-08-22 20:08 ` [PATCH] socklnd: Remove static initialization to NULL or 0 Marco Cyriacks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®