* [PATCH] gpio: bt8xx: fix release of managed resources
@ 2014-08-27 1:39 Michael Auchter
2014-08-29 12:31 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Michael Auchter @ 2014-08-27 1:39 UTC (permalink / raw)
To: Michael Buesch, Linus Walleij, Alexandre Courbot, linux-kernel
Cc: Michael Auchter
These resources are managed by devres, and should not be explicitly
released.
Signed-off-by: Michael Auchter <a@phire.org>
---
drivers/gpio/gpio-bt8xx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c
index 6557147..7e4c43c 100644
--- a/drivers/gpio/gpio-bt8xx.c
+++ b/drivers/gpio/gpio-bt8xx.c
@@ -241,9 +241,6 @@ static void bt8xxgpio_remove(struct pci_dev *pdev)
bgwrite(~0x0, BT848_INT_STAT);
bgwrite(0x0, BT848_GPIO_OUT_EN);
- iounmap(bg->mmio);
- release_mem_region(pci_resource_start(pdev, 0),
- pci_resource_len(pdev, 0));
pci_disable_device(pdev);
}
--
1.8.5.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: bt8xx: fix release of managed resources
2014-08-27 1:39 [PATCH] gpio: bt8xx: fix release of managed resources Michael Auchter
@ 2014-08-29 12:31 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-08-29 12:31 UTC (permalink / raw)
To: Michael Auchter; +Cc: Michael Buesch, Alexandre Courbot, linux-kernel
On Wed, Aug 27, 2014 at 3:39 AM, Michael Auchter <a@phire.org> wrote:
> These resources are managed by devres, and should not be explicitly
> released.
>
> Signed-off-by: Michael Auchter <a@phire.org>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-29 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-27 1:39 [PATCH] gpio: bt8xx: fix release of managed resources Michael Auchter
2014-08-29 12:31 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®