* [PATCH] ARM: zynq: DT: Add LEDs to zc702 DT
@ 2014-08-28 16:22 Soren Brinkmann
2014-08-28 17:15 ` Sören Brinkmann
[not found] ` <20140828171536.GB4345@xsjandreislx>
0 siblings, 2 replies; 3+ messages in thread
From: Soren Brinkmann @ 2014-08-28 16:22 UTC (permalink / raw)
To: Michal Simek
Cc: Sören Brinkmann, Ezra Savard, linux-kernel,
linux-arm-kernel, devicetree, Ezra Savard
From: Ezra Savard <ezra.savard@xilinx.com>
Adds LEDs to the zc702 devicetree for use with the leds-gpio driver.
Signed-off-by: Ezra Savard <ezra.savard@xilinx.com>
Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
index 835c3089c61c..4e9fe26b3e85 100644
--- a/arch/arm/boot/dts/zynq-zc702.dts
+++ b/arch/arm/boot/dts/zynq-zc702.dts
@@ -27,6 +27,16 @@
bootargs = "console=ttyPS0,115200 earlyprintk";
};
+ gpio-leds {
+ compatible = "gpio-leds";
+
+ led-ds23 {
+ label = "ds23";
+ gpios = <&gpio0 10 0>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+
};
&can0 {
--
2.1.0.1.g27b9230
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: zynq: DT: Add LEDs to zc702 DT
2014-08-28 16:22 [PATCH] ARM: zynq: DT: Add LEDs to zc702 DT Soren Brinkmann
@ 2014-08-28 17:15 ` Sören Brinkmann
[not found] ` <20140828171536.GB4345@xsjandreislx>
1 sibling, 0 replies; 3+ messages in thread
From: Sören Brinkmann @ 2014-08-28 17:15 UTC (permalink / raw)
To: Michal Simek
Cc: Ezra Savard, linux-kernel, linux-arm-kernel, devicetree, Ezra Savard
On Thu, 2014-08-28 at 09:22AM -0700, Soren Brinkmann wrote:
> From: Ezra Savard <ezra.savard@xilinx.com>
>
> Adds LEDs to the zc702 devicetree for use with the leds-gpio driver.
>
> Signed-off-by: Ezra Savard <ezra.savard@xilinx.com>
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 835c3089c61c..4e9fe26b3e85 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -27,6 +27,16 @@
> bootargs = "console=ttyPS0,115200 earlyprintk";
> };
>
> + gpio-leds {
The node name should rather be just 'leds'. That slipped through, sorry.
Do you want a v2 for that?
Soren
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: zynq: DT: Add LEDs to zc702 DT
[not found] ` <20140828171536.GB4345@xsjandreislx>
@ 2014-08-29 4:57 ` Michal Simek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2014-08-29 4:57 UTC (permalink / raw)
To: Sören Brinkmann, Michal Simek
Cc: Ezra Savard, linux-kernel, linux-arm-kernel, devicetree, Ezra Savard
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On 08/28/2014 07:15 PM, Sören Brinkmann wrote:
> On Thu, 2014-08-28 at 09:22AM -0700, Soren Brinkmann wrote:
>> From: Ezra Savard <ezra.savard@xilinx.com>
>>
>> Adds LEDs to the zc702 devicetree for use with the leds-gpio driver.
>>
>> Signed-off-by: Ezra Savard <ezra.savard@xilinx.com>
>> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> ---
>> arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
>> index 835c3089c61c..4e9fe26b3e85 100644
>> --- a/arch/arm/boot/dts/zynq-zc702.dts
>> +++ b/arch/arm/boot/dts/zynq-zc702.dts
>> @@ -27,6 +27,16 @@
>> bootargs = "console=ttyPS0,115200 earlyprintk";
>> };
>>
>> + gpio-leds {
> The node name should rather be just 'leds'. That slipped through, sorry.
> Do you want a v2 for that?
yes, please send v2.
Thanks,
Michal
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-29 4:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-28 16:22 [PATCH] ARM: zynq: DT: Add LEDs to zc702 DT Soren Brinkmann
2014-08-28 17:15 ` Sören Brinkmann
[not found] ` <20140828171536.GB4345@xsjandreislx>
2014-08-29 4:57 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®