mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Demers <alexandre.f.demers@gmail.com>
To: hpa@zytor.com
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] x86/tsc trivial: Changes Fast TSC calibration failed from error to warning
Date: Sat, 30 Aug 2014 17:33:27 -0400	[thread overview]
Message-ID: <1409434407-14824-1-git-send-email-alexandre.f.demers@gmail.com> (raw)

Most users see this message when booting without knowning that it is of 
mostly no importance and that TSC calibration may have succeeded by 
another way.

As explained thoroufly by Paul Bolle in 2012 
(http://lkml.iu.edu//hypermail/linux/kernel/1209.3/00224.html), 
"Fast TSC calibration failed" should not be considered as an error since 
other calibration methods are being tried afterward. At most, 
those send a warning if they fail (not an error). So let's change 
the message from error to warning.

It should also fix bug 75971: fast tsc calibration faild on ubuntu 14.04 LTS

Tested on kernel 3.17-rc2.

Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>

---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index b6025f9..5a22022 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -617,7 +617,7 @@ static unsigned long quick_pit_calibrate(void)
 			goto success;
 		}
 	}
-	pr_err("Fast TSC calibration failed\n");
+	pr_warn("Fast TSC calibration failed\n");
 	return 0;
 
 success:
-- 
2.1.0


                 reply	other threads:[~2014-08-30 21:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409434407-14824-1-git-send-email-alexandre.f.demers@gmail.com \
    --to=alexandre.f.demers@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®