mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86/tsc trivial: Changes Fast TSC calibration failed from error to warning
@ 2014-08-30 21:33 Alexandre Demers
  0 siblings, 0 replies; only message in thread
From: Alexandre Demers @ 2014-08-30 21:33 UTC (permalink / raw)
  To: hpa; +Cc: trivial, linux-kernel

Most users see this message when booting without knowning that it is of 
mostly no importance and that TSC calibration may have succeeded by 
another way.

As explained thoroufly by Paul Bolle in 2012 
(http://lkml.iu.edu//hypermail/linux/kernel/1209.3/00224.html), 
"Fast TSC calibration failed" should not be considered as an error since 
other calibration methods are being tried afterward. At most, 
those send a warning if they fail (not an error). So let's change 
the message from error to warning.

It should also fix bug 75971: fast tsc calibration faild on ubuntu 14.04 LTS

Tested on kernel 3.17-rc2.

Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>

---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index b6025f9..5a22022 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -617,7 +617,7 @@ static unsigned long quick_pit_calibrate(void)
 			goto success;
 		}
 	}
-	pr_err("Fast TSC calibration failed\n");
+	pr_warn("Fast TSC calibration failed\n");
 	return 0;
 
 success:
-- 
2.1.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-08-30 21:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-30 21:33 [PATCH] x86/tsc trivial: Changes Fast TSC calibration failed from error to warning Alexandre Demers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®