[GIT PULL] target updates for v3.17-rc3

[GIT PULL] target updates for v3.17-rc3

[Nicholas A. Bellinger]

Hi Linus,

Here are the target pending updates for v3.17-rc3.  Please go ahead and
pull from:

  git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next

Note that these patches where originally intended for -rc1, but missed
the merge window.  They are mostly iser-target related bug-fixes, along
with a few other very minor cleanups.

Thank you,

--nab

Andreea-Cristina Bernat (1):
  tcm_fc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

Himangi Saraogi (1):
  target/configfs: Remove unnecessary null test

Nicholas Bellinger (1):
  iscsi-target: Ignore ICF_GOT_LAST_DATAOUT during Data-Out ITT lookup

Rasmus Villemoes (1):
  target: target_core_ua_h: Add #define of include guard

Rickard Strandqvist (1):
  target: target_core_transport.c: Cleaning up missing null-terminate
    in conjunction with strncpy

Sagi Grimberg (4):
  Target/iser: Get isert_conn reference once got to connected_handler
  Target/iser: Don't put isert_conn inside disconnected handler
  Target/iser: Avoid calling rdma_disconnect twice
  Target/iser: Fix initiator_depth and responder_resources

 drivers/infiniband/ulp/isert/ib_isert.c      |   20 +++---
 drivers/target/iscsi/iscsi_target_util.c     |    2 +
 drivers/target/target_core_fabric_configfs.c |    3 +-
 drivers/target/target_core_transport.c       |   86 +++++++++++++-------------
 drivers/target/target_core_ua.h              |    1 +
 drivers/target/tcm_fc/tfc_sess.c             |    2 +-
 6 files changed, 60 insertions(+), 54 deletions(-)

Re: [GIT PULL] target updates for v3.17-rc3

[Linus Torvalds]

On Sun, Aug 31, 2014 at 11:59 AM, Nicholas A. Bellinger
<nab@linux-iscsi.org> wrote:
>
> Note that these patches where originally intended for -rc1, but missed
> the merge window.  They are mostly iser-target related bug-fixes, along
> with a few other very minor cleanups.

So this pull request was strictly speaking too late for rc3, but I
went "what the hell, it's small" and pulled it anyway.

And then I get this:

  drivers/target/target_core_transport.c: In function
‘transport_dump_vpd_ident_type’:
  drivers/target/target_core_transport.c:956:3: warning: passing
argument 1 of ‘strlen’ makes pointer from integer without a cast
[enabled by default]
     len = strlen(len);
     ^
  In file included from include/linux/bitmap.h:8:0,
                   from include/linux/cpumask.h:11,
                   from ./arch/x86/include/asm/cpumask.h:4,
                   from ./arch/x86/include/asm/msr.h:10,
                   from ./arch/x86/include/asm/processor.h:20,
                   from ./arch/x86/include/asm/archrandom.h:26,
                   from include/linux/random.h:81,
                   from include/linux/net.h:22,
                   from drivers/target/target_core_transport.c:26:
  include/linux/string.h:80:24: note: expected ‘const char *’ but
argument is of type ‘int’
   extern __kernel_size_t strlen(const char *);
                          ^

and I just go "Yeah, that broken crap can wait until 3.18 after all".

So it got unpulled.

That "strlen(len)" should clearly be a "strlen(buf)" in that commit
6cfa853ceee4, but equally clearly this pull request was pure and utter
garbage, and that "cleanup" commit was shit that nobody had ever even
bothered to compile.

Thanks, but no. And please never send this kind of untested crap to me again,

                   Linus

Re: [GIT PULL] target updates for v3.17-rc3

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2131 bytes --]

Hi Nicholas,

On Sun, 31 Aug 2014 17:51:07 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Sun, Aug 31, 2014 at 11:59 AM, Nicholas A. Bellinger
> <nab@linux-iscsi.org> wrote:
> >
> > Note that these patches where originally intended for -rc1, but missed
> > the merge window.  They are mostly iser-target related bug-fixes, along
> > with a few other very minor cleanups.
> 
> So this pull request was strictly speaking too late for rc3, but I
> went "what the hell, it's small" and pulled it anyway.
> 
> And then I get this:
> 
>   drivers/target/target_core_transport.c: In function
> ‘transport_dump_vpd_ident_type’:
>   drivers/target/target_core_transport.c:956:3: warning: passing
> argument 1 of ‘strlen’ makes pointer from integer without a cast
> [enabled by default]
>      len = strlen(len);
>      ^
>   In file included from include/linux/bitmap.h:8:0,
>                    from include/linux/cpumask.h:11,
>                    from ./arch/x86/include/asm/cpumask.h:4,
>                    from ./arch/x86/include/asm/msr.h:10,
>                    from ./arch/x86/include/asm/processor.h:20,
>                    from ./arch/x86/include/asm/archrandom.h:26,
>                    from include/linux/random.h:81,
>                    from include/linux/net.h:22,
>                    from drivers/target/target_core_transport.c:26:
>   include/linux/string.h:80:24: note: expected ‘const char *’ but
> argument is of type ‘int’
>    extern __kernel_size_t strlen(const char *);
>                           ^
> 
> and I just go "Yeah, that broken crap can wait until 3.18 after all".
> 
> So it got unpulled.
> 
> That "strlen(len)" should clearly be a "strlen(buf)" in that commit
> 6cfa853ceee4, but equally clearly this pull request was pure and utter
> garbage, and that "cleanup" commit was shit that nobody had ever even
> bothered to compile.

I noticed this in linux-next today as well (in the target-update
tree).  Could I have that cleaned up, please?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]