From: Joe Perches <joe@perches.com>
To: Chaitra Ramaiah <linux.delve@gmail.com>
Cc: gregkh@linuxfoundation.org, burzalodowa@gmail.com,
anarey@gmail.com, rmfrfs@gmail.com, gdonald@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192u: fix brace style coding issue in r819xU_firmware.c
Date: Thu, 04 Sep 2014 08:32:30 -0700 [thread overview]
Message-ID: <1409844750.2770.10.camel@joe-AO725> (raw)
In-Reply-To: <1409843463-3702-2-git-send-email-linux.delve@gmail.com>
On Thu, 2014-09-04 at 20:41 +0530, Chaitra Ramaiah wrote:
[]
> diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c
[]
> @@ -153,11 +153,10 @@ static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
> break;
> }while(check_bootOk_time--);
>
> - if (!(CPU_status&CPU_GEN_BOOT_RDY)) {
> + if (!(CPU_status&CPU_GEN_BOOT_RDY))
> goto CPUCheckMainCodeOKAndTurnOnCPU_Fail;
> - } else {
> + else
> RT_TRACE(COMP_FIRMWARE, "Download Firmware: Boot ready!\n");
> - }
This would be better as:
if (!(CPU_status & CPU_GEN_BOOT_RDY))
goto CPUCheckMainCodeOKandTurnOnCPU_Fail;
RT_TRACE(etc...)
It'd be nice to eliminate the StudlyCaps and
rather long labels too.
next prev parent reply other threads:[~2014-09-04 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 15:11 Chaitra Ramaiah
2014-09-04 15:11 ` Chaitra Ramaiah
2014-09-04 15:28 ` Joe Perches
2014-09-04 15:32 ` Joe Perches [this message]
[not found] <yes>
2014-09-04 13:50 ` linux.delve
2014-09-04 14:09 ` Chaitra Ramaiah
2014-09-04 14:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409844750.2770.10.camel@joe-AO725 \
--to=joe@perches.com \
--cc=anarey@gmail.com \
--cc=burzalodowa@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.delve@gmail.com \
--cc=rmfrfs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®