From: Ted Percival <ted@tedp.id.au>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
David Rientjes <rientjes@google.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Christoph Lameter <cl@linux.com>, Ted Percival <ted@tedp.id.au>,
"open list:X86 ARCHITECTURE..." <linux-kernel@vger.kernel.org>
Cc: "maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
"open list:X86 ARCHITECTURE..." <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86, apic: Fix unmasked CPU initialization
Date: Mon, 8 Sep 2014 10:15:37 -0600 [thread overview]
Message-ID: <1410192947-6830-1-git-send-email-ted@tedp.id.au> (raw)
Commit 4ba2968420fa removed the application of the CPU mask resulting
in a hang when initializing the first CPU at boot:
x86: Booting SMP configuration
.... node #0, CPUs: #1_
Fixes: 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
Signed-off-by: Ted Percival <ted@tedp.id.au>
---
arch/x86/kernel/apic/x2apic_cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 1f5d5f2..e658f21 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
* and be sure it's manipulated with irq off.
*/
ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+ cpumask_copy(ipi_mask_ptr, mask);
/*
* The idea is to send one IPI per cluster.
--
1.9.1
next reply other threads:[~2014-09-08 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 16:15 Ted Percival [this message]
2014-09-08 17:50 ` Christoph Lameter
2014-09-09 12:50 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410192947-6830-1-git-send-email-ted@tedp.id.au \
--to=ted@tedp.id.au \
--cc=cl@linux.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome