* [PATCH] x86, apic: Fix unmasked CPU initialization
@ 2014-09-08 16:15 Ted Percival
2014-09-08 17:50 ` Christoph Lameter
2014-09-09 12:50 ` Thomas Gleixner
0 siblings, 2 replies; 3+ messages in thread
From: Ted Percival @ 2014-09-08 16:15 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
maintainer:X86 ARCHITECTURE...,
David Rientjes, Paul Gortmaker, Christoph Lameter, Ted Percival,
open list:X86 ARCHITECTURE...
Cc: maintainer:X86 ARCHITECTURE..., open list:X86 ARCHITECTURE...
Commit 4ba2968420fa removed the application of the CPU mask resulting
in a hang when initializing the first CPU at boot:
x86: Booting SMP configuration
.... node #0, CPUs: #1_
Fixes: 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
Signed-off-by: Ted Percival <ted@tedp.id.au>
---
arch/x86/kernel/apic/x2apic_cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 1f5d5f2..e658f21 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
* and be sure it's manipulated with irq off.
*/
ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+ cpumask_copy(ipi_mask_ptr, mask);
/*
* The idea is to send one IPI per cluster.
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86, apic: Fix unmasked CPU initialization
2014-09-08 16:15 [PATCH] x86, apic: Fix unmasked CPU initialization Ted Percival
@ 2014-09-08 17:50 ` Christoph Lameter
2014-09-09 12:50 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2014-09-08 17:50 UTC (permalink / raw)
To: Ted Percival
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
maintainer:X86 ARCHITECTURE...,
David Rientjes, Paul Gortmaker, open list:X86 ARCHITECTURE...
On Mon, 8 Sep 2014, Ted Percival wrote:
> Commit 4ba2968420fa removed the application of the CPU mask resulting
> in a hang when initializing the first CPU at boot:
Argh.
Reviewed-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86, apic: Fix unmasked CPU initialization
2014-09-08 16:15 [PATCH] x86, apic: Fix unmasked CPU initialization Ted Percival
2014-09-08 17:50 ` Christoph Lameter
@ 2014-09-09 12:50 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2014-09-09 12:50 UTC (permalink / raw)
To: Ted Percival
Cc: Ingo Molnar, H. Peter Anvin, maintainer:X86 ARCHITECTURE...,
David Rientjes, Paul Gortmaker, Christoph Lameter,
open list:X86 ARCHITECTURE...
On Mon, 8 Sep 2014, Ted Percival wrote:
> Commit 4ba2968420fa removed the application of the CPU mask resulting
> in a hang when initializing the first CPU at boot:
>
> x86: Booting SMP configuration
> .... node #0, CPUs: #1_
>
> Fixes: 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
I can't find that commit in any of my trees.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-09 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-08 16:15 [PATCH] x86, apic: Fix unmasked CPU initialization Ted Percival
2014-09-08 17:50 ` Christoph Lameter
2014-09-09 12:50 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome