* [PATCH Resend] drivers: net: b44: Fix typo in returning multicast stats
@ 2014-09-11 22:19 Mark Einon
2014-09-12 22:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mark Einon @ 2014-09-11 22:19 UTC (permalink / raw)
To: gary.zambrano; +Cc: netdev, linux-kernel, Mark Einon
nstat->multicast refers to received packets, not transmitted as
is returned here. Change it so that received packet stats are
given.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
---
changing to send to alternate address for Gary Zambrano, maintainers entry bounced.
drivers/net/ethernet/broadcom/b44.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
index 4a7028d..d588136 100644
--- a/drivers/net/ethernet/broadcom/b44.c
+++ b/drivers/net/ethernet/broadcom/b44.c
@@ -1697,7 +1697,7 @@ static struct rtnl_link_stats64 *b44_get_stats64(struct net_device *dev,
hwstat->tx_underruns +
hwstat->tx_excessive_cols +
hwstat->tx_late_cols);
- nstat->multicast = hwstat->tx_multicast_pkts;
+ nstat->multicast = hwstat->rx_multicast_pkts;
nstat->collisions = hwstat->tx_total_cols;
nstat->rx_length_errors = (hwstat->rx_oversize_pkts +
--
2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH Resend] drivers: net: b44: Fix typo in returning multicast stats
2014-09-11 22:19 [PATCH Resend] drivers: net: b44: Fix typo in returning multicast stats Mark Einon
@ 2014-09-12 22:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-12 22:24 UTC (permalink / raw)
To: mark.einon; +Cc: gary.zambrano, netdev, linux-kernel
From: Mark Einon <mark.einon@gmail.com>
Date: Thu, 11 Sep 2014 23:19:49 +0100
> nstat->multicast refers to received packets, not transmitted as
> is returned here. Change it so that received packet stats are
> given.
>
> Signed-off-by: Mark Einon <mark.einon@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-12 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-11 22:19 [PATCH Resend] drivers: net: b44: Fix typo in returning multicast stats Mark Einon
2014-09-12 22:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome