From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH 0/6] Small seqfile-use improvements
Date: Fri, 12 Sep 2014 11:25:48 +0200 [thread overview]
Message-ID: <1410513954-28909-1-git-send-email-linux@rasmusvillemoes.dk> (raw)
Patches 1-3 are semantic patches for replacing certain seq_* calls
with simpler equivalents, e.g. seq_printf(m, "literal") -> seq_puts(m,
"literal"). 1 and 3 are guaranteed to preserve the semantics of the
code. 2 may change it slightly, since if the seq_file overflows midway
through a series of seq_puts calls, some of the strings have been
printed; after applying 2, it is all-or-nothing. However, consecutive
seq_puts calls with literal strings is mostly used to print long
headers, so overflow is very unlikely.
As an example, I applied these coccinelle scripts to kernel/trace/.
The net result is a nice round, but admittedly tiny, 256 byte .text
reduction.
Rasmus Villemoes (6):
Coccinelle: Semantic patch for replacing puts with putc
Coccinelle: Semantic patch for joining seq_puts calls
Coccinelle: Semantic patch for replacing seq_printf calls with
equivalent but simpler functions
trace: Replace seq_printf by simpler equivalents
trace: Merge consecutive seq_puts calls
trace: Replace single-character seq_puts with seq_putc
kernel/trace/ftrace.c | 30 +++---
kernel/trace/trace.c | 86 ++++++++-------
kernel/trace/trace_branch.c | 31 +++---
kernel/trace/trace_events.c | 4 +-
kernel/trace/trace_events_trigger.c | 6 +-
kernel/trace/trace_functions.c | 2 +-
kernel/trace/trace_functions_graph.c | 28 ++---
kernel/trace/trace_kprobe.c | 12 +--
kernel/trace/trace_printk.c | 2 +-
kernel/trace/trace_uprobe.c | 4 +-
scripts/coccinelle/api/seq_printf.cocci | 156 +++++++++++++++++++++++++++
scripts/coccinelle/api/seq_puts_concat.cocci | 71 ++++++++++++
scripts/coccinelle/api/seq_putsc.cocci | 61 +++++++++++
13 files changed, 393 insertions(+), 100 deletions(-)
create mode 100644 scripts/coccinelle/api/seq_printf.cocci
create mode 100644 scripts/coccinelle/api/seq_puts_concat.cocci
create mode 100644 scripts/coccinelle/api/seq_putsc.cocci
--
2.0.4
next reply other threads:[~2014-09-12 9:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 9:25 Rasmus Villemoes [this message]
2014-09-12 9:25 ` [PATCH 1/6] Coccinelle: Semantic patch for replacing puts with putc Rasmus Villemoes
2014-09-12 11:08 ` SF Markus Elfring
2014-09-12 9:25 ` [PATCH 2/6] Coccinelle: Semantic patch for joining seq_puts calls Rasmus Villemoes
2014-09-12 9:25 ` [PATCH 3/6] Coccinelle: Semantic patch for replacing seq_printf calls with equivalent but simpler functions Rasmus Villemoes
2014-09-12 9:25 ` [PATCH 4/6] trace: Replace seq_printf by simpler equivalents Rasmus Villemoes
2014-11-05 22:34 ` Steven Rostedt
2014-11-05 22:44 ` Rasmus Villemoes
2014-11-06 0:34 ` Steven Rostedt
2014-11-05 22:51 ` Joe Perches
2014-11-06 0:38 ` Steven Rostedt
2014-11-06 0:47 ` Joe Perches
2014-11-08 20:42 ` [PATCH v2 0/3] trace: Use simpler seq_file functions Rasmus Villemoes
2014-11-08 20:42 ` [PATCH v2 1/3] trace: Replace seq_printf by simpler equivalents Rasmus Villemoes
2014-11-14 2:31 ` Steven Rostedt
2014-11-08 20:42 ` [PATCH v2 2/3] trace: Merge consecutive seq_puts calls Rasmus Villemoes
2014-11-08 20:42 ` [PATCH v2 3/3] trace: Replace single-character seq_puts with seq_putc Rasmus Villemoes
2014-11-14 2:34 ` Steven Rostedt
2014-09-12 9:25 ` [PATCH 5/6] trace: Merge consecutive seq_puts calls Rasmus Villemoes
2014-09-12 9:25 ` [PATCH 6/6] trace: Replace single-character seq_puts with seq_putc Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410513954-28909-1-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=Julia.Lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®