mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 1/3] trace: Replace seq_printf by simpler equivalents
Date: Thu, 13 Nov 2014 21:31:58 -0500	[thread overview]
Message-ID: <20141113213158.12fcca7d@gandalf.local.home> (raw)
In-Reply-To: <1415479332-25944-2-git-send-email-linux@rasmusvillemoes.dk>

On Sat,  8 Nov 2014 21:42:10 +0100
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:


> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");




>  
> @@ -840,7 +840,7 @@ static int probes_seq_show(struct seq_file *m, void *v)
>  
>  	for (i = 0; i < tk->tp.nr_args; i++)
>  		seq_printf(m, " %s=%s", tk->tp.args[i].name, tk->tp.args[i].comm);
> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");
>  
>  	return 0;
>  }
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 33ff6a2..184aec1 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -606,7 +606,7 @@ static int probes_seq_show(struct seq_file *m, void *v)
>  	for (i = 0; i < tu->tp.nr_args; i++)
>  		seq_printf(m, " %s=%s", tu->tp.args[i].name, tu->tp.args[i].comm);
>  
> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");

These can actually be seq_putc(m, '\n');

I saw this because one of them conflicted with a change I already had.

No need to resend, I'll just update them myself. Trivial enough.

-- Steve

>  	return 0;
>  }
>  


  reply	other threads:[~2014-11-14  2:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12  9:25 [PATCH 0/6] Small seqfile-use improvements Rasmus Villemoes
2014-09-12  9:25 ` [PATCH 1/6] Coccinelle: Semantic patch for replacing puts with putc Rasmus Villemoes
2014-09-12 11:08   ` SF Markus Elfring
2014-09-12  9:25 ` [PATCH 2/6] Coccinelle: Semantic patch for joining seq_puts calls Rasmus Villemoes
2014-09-12  9:25 ` [PATCH 3/6] Coccinelle: Semantic patch for replacing seq_printf calls with equivalent but simpler functions Rasmus Villemoes
2014-09-12  9:25 ` [PATCH 4/6] trace: Replace seq_printf by simpler equivalents Rasmus Villemoes
2014-11-05 22:34   ` Steven Rostedt
2014-11-05 22:44     ` Rasmus Villemoes
2014-11-06  0:34       ` Steven Rostedt
2014-11-05 22:51     ` Joe Perches
2014-11-06  0:38       ` Steven Rostedt
2014-11-06  0:47         ` Joe Perches
2014-11-08 20:42   ` [PATCH v2 0/3] trace: Use simpler seq_file functions Rasmus Villemoes
2014-11-08 20:42     ` [PATCH v2 1/3] trace: Replace seq_printf by simpler equivalents Rasmus Villemoes
2014-11-14  2:31       ` Steven Rostedt [this message]
2014-11-08 20:42     ` [PATCH v2 2/3] trace: Merge consecutive seq_puts calls Rasmus Villemoes
2014-11-08 20:42     ` [PATCH v2 3/3] trace: Replace single-character seq_puts with seq_putc Rasmus Villemoes
2014-11-14  2:34       ` Steven Rostedt
2014-09-12  9:25 ` [PATCH 5/6] trace: Merge consecutive seq_puts calls Rasmus Villemoes
2014-09-12  9:25 ` [PATCH 6/6] trace: Replace single-character seq_puts with seq_putc Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141113213158.12fcca7d@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®