[PATCH 1/1] checkpatch: fix perl v5.20 warning: useless use of greediness modifier

[PATCH 1/1] checkpatch: fix perl v5.20 warning: useless use of greediness modifier

[Roman Pen]

on my perl v5.20 I got:
  Useless use of greediness modifier '+' in regex; marked by
  <-- HERE in m/(^\+.*) {8,8}+ <-- HERE \t/ at ./scripts/checkpatch.pl line 2427.

greediness modifier '+' in construction '\s{8,8}+' does not make
any sense, because we already specify how many chars do we expect.

Also we can avoid second ',8' and use simple '\s{8}'.

Signed-off-by: Roman Pen <r.peniaev@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4d08b39..ccd3234 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2424,7 +2424,7 @@ sub process {
 				"please, no space before tabs\n" . $herevet) &&
 			    $fix) {
 				while ($fixed[$fixlinenr] =~
-					   s/(^\+.*) {8,8}+\t/$1\t\t/) {}
+					   s/(^\+.*) {8}\t/$1\t\t/) {}
 				while ($fixed[$fixlinenr] =~
 					   s/(^\+.*) +\t/$1\t/) {}
 			}
-- 
2.0.0

Re: [PATCH 1/1] checkpatch: fix perl v5.20 warning: useless use of greediness modifier

[Joe Perches]

On Tue, 2014-09-16 at 00:12 +0900, Roman Pen wrote:
> on my perl v5.20 I got:
>   Useless use of greediness modifier '+' in regex; marked by
>   <-- HERE in m/(^\+.*) {8,8}+ <-- HERE \t/ at ./scripts/checkpatch.pl line 2427.
> 
> greediness modifier '+' in construction '\s{8,8}+' does not make
> any sense, because we already specify how many chars do we expect.
> 
> Also we can avoid second ',8' and use simple '\s{8}'.

Thanks Roman, it's already fixed in -next.

http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/scripts/checkpatch.pl?id=66cb4ee0e52ca721f609fd5eec16187189ae5fda