mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kernel/kallsyms.c: use __seq_open_private()
@ 2014-09-18  9:17 Rob Jones
  0 siblings, 0 replies; only message in thread
From: Rob Jones @ 2014-09-18  9:17 UTC (permalink / raw)
  To: akpm; +Cc: gidisrael, linux-kernel, linux-kernel, rob.jones

Reduce boilerplate code by using __seq_open_private() instead of seq_open()
in kallsyms_open().

Signed-off-by: Rob Jones <rob.jones@codethink.co.uk>
---
 kernel/kallsyms.c |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index cb0cf37..606664d 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -565,19 +565,12 @@ static int kallsyms_open(struct inode *inode, struct file *file)
 	 * using get_symbol_offset for every symbol.
 	 */
 	struct kallsym_iter *iter;
-	int ret;
-
-	iter = kmalloc(sizeof(*iter), GFP_KERNEL);
+	iter = __seq_open_private(file, &kallsyms_op, sizeof(*iter));
 	if (!iter)
 		return -ENOMEM;
 	reset_iter(iter, 0);
 
-	ret = seq_open(file, &kallsyms_op);
-	if (ret == 0)
-		((struct seq_file *)file->private_data)->private = iter;
-	else
-		kfree(iter);
-	return ret;
+	return 0;
 }
 
 #ifdef	CONFIG_KGDB_KDB
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-09-18  9:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-18  9:17 [PATCH] kernel/kallsyms.c: use __seq_open_private() Rob Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®