From: Joe Perches <joe@perches.com>
To: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Todd Brandt <todd.e.brandt@intel.com>, Tejun Heo <tj@kernel.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: sas_ata: change ata_<foo>_printk routines to return void
Date: Mon, 22 Sep 2014 10:01:24 -0700 [thread overview]
Message-ID: <1411405284.2952.42.camel@joe-AO725> (raw)
The return value is not used by callers of this function
so change the function to return void.
Signed-off-by: Joe Perches <joe@perches.com>
---
This change is associated to a desire to eventually
change printk to return void.
drivers/scsi/libsas/sas_ata.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 766098a..2a15a54 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -375,26 +375,23 @@ static int local_ata_check_ready(struct ata_link *link)
}
}
-static int sas_ata_printk(const char *level, const struct domain_device *ddev,
- const char *fmt, ...)
+static void sas_ata_printk(const char *level, const struct domain_device *ddev,
+ const char *fmt, ...)
{
struct ata_port *ap = ddev->sata_dev.ap;
struct device *dev = &ddev->rphy->dev;
struct va_format vaf;
va_list args;
- int r;
va_start(args, fmt);
vaf.fmt = fmt;
vaf.va = &args;
- r = printk("%ssas: ata%u: %s: %pV",
- level, ap->print_id, dev_name(dev), &vaf);
+ printk("%ssas: ata%u: %s: %pV",
+ level, ap->print_id, dev_name(dev), &vaf);
va_end(args);
-
- return r;
}
static int sas_ata_hard_reset(struct ata_link *link, unsigned int *class,
reply other threads:[~2014-09-22 17:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411405284.2952.42.camel@joe-AO725 \
--to=joe@perches.com \
--cc=JBottomley@parallels.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
--cc=todd.e.brandt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®