mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scsi: sas_ata: change ata_<foo>_printk routines to return void
@ 2014-09-22 17:01 Joe Perches
  0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2014-09-22 17:01 UTC (permalink / raw)
  To: James E.J. Bottomley
  Cc: Dan Williams, Todd Brandt, Tejun Heo, linux-scsi, linux-kernel

The return value is not used by callers of this function
so change the function to return void.

Signed-off-by: Joe Perches <joe@perches.com>
---
This change is associated to a desire to eventually
change printk to return void.

 drivers/scsi/libsas/sas_ata.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 766098a..2a15a54 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -375,26 +375,23 @@ static int local_ata_check_ready(struct ata_link *link)
 	}
 }
 
-static int sas_ata_printk(const char *level, const struct domain_device *ddev,
-			  const char *fmt, ...)
+static void sas_ata_printk(const char *level, const struct domain_device *ddev,
+			   const char *fmt, ...)
 {
 	struct ata_port *ap = ddev->sata_dev.ap;
 	struct device *dev = &ddev->rphy->dev;
 	struct va_format vaf;
 	va_list args;
-	int r;
 
 	va_start(args, fmt);
 
 	vaf.fmt = fmt;
 	vaf.va = &args;
 
-	r = printk("%ssas: ata%u: %s: %pV",
-		   level, ap->print_id, dev_name(dev), &vaf);
+	printk("%ssas: ata%u: %s: %pV",
+	       level, ap->print_id, dev_name(dev), &vaf);
 
 	va_end(args);
-
-	return r;
 }
 
 static int sas_ata_hard_reset(struct ata_link *link, unsigned int *class,



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-09-22 17:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-22 17:01 [PATCH] scsi: sas_ata: change ata_<foo>_printk routines to return void Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®