From: Ong Boon Leong <boon.leong.ong@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
"Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Subject: [PATCH] x86, setup: Additional __flush_tlb for Quak X1000
Date: Fri, 26 Sep 2014 12:30:26 +0800 [thread overview]
Message-ID: <1411705827-2522-1-git-send-email-boon.leong.ong@intel.com> (raw)
Hi,
With respect to submission sent below:
"x86: Quark: Comment setup_arch for TLB/PGE bugfix"
__flush_tlb_all() does not take __flush_tlb() because cpu_has_pge
flag that is setup in head_32.S by CPUID and not changed much later.
So, the comment added are incorrect. Explaination below:
For change on:
"x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead"
The X86_FEATURE_PGE cap is cleared in early_cpu_init() -->
early_identify_cpu() --> early_init_intel(). And, early_cpu_init()
is performed after the __flush_tlb_all() step.
Anyway, thanks to Bryan for submitting patch for Quark SoC.
FYI, the suggestion to add __flush_tlb() has been discussed with some
of the kernel developers CC'ed below inclusing HPA himself.
Thank you very much,
Ong Boon Leong
Ong Boon Leong (1):
x86, setup: add __flush_tlb() for Intel Quark X1000
arch/x86/kernel/setup.c | 7 +++++++
1 file changed, 7 insertions(+)
--
1.7.9.5
next reply other threads:[~2014-09-26 4:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 4:30 Ong Boon Leong [this message]
2014-09-26 4:30 ` [PATCH] x86, setup: add __flush_tlb() for Intel Quark X1000 Ong Boon Leong
2014-09-26 5:32 ` Dave Hansen
2014-09-26 8:44 ` Bryan O'Donoghue
2014-09-26 14:20 ` Dave Hansen
2014-09-26 14:30 ` Bryan O'Donoghue
2014-09-26 15:00 ` Bryan O'Donoghue
2014-09-26 17:22 ` Bryan O'Donoghue
2014-09-26 8:54 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411705827-2522-1-git-send-email-boon.leong.ong@intel.com \
--to=boon.leong.ong@intel.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pure.logic@nexus-software.ie \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®