From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Ong Boon Leong <boon.leong.ong@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] x86, setup: add __flush_tlb() for Intel Quark X1000
Date: Fri, 26 Sep 2014 09:54:07 +0100 [thread overview]
Message-ID: <542529AF.3050601@nexus-software.ie> (raw)
In-Reply-To: <1411705827-2522-2-git-send-email-boon.leong.ong@intel.com>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 41ead8d..90e0b85 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -880,6 +880,13 @@ void __init setup_arch(char **cmdline_p)
>
> load_cr3(swapper_pg_dir);
> __flush_tlb_all();
> + /*
> + * Quark X1000 wrongly advertises PGE, add __flush_tlb()
> + * below to make sure TLB is flushed correctly in the early stage
> + * of setup_arch() for Quark X1000.
> + * X86_FEATURE_PGE flag is only setup later stage at early_cpu_init();
> + */
> + __flush_tlb();
> #else
> printk(KERN_INFO "Command line: %s\n", boot_command_line);
> #endif
Sorry guys.
Just actually *read* the patch now.
If the above text works for Ingo and Henrique then it works for me too.
--
BOD
prev parent reply other threads:[~2014-09-26 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 4:30 [PATCH] x86, setup: Additional __flush_tlb for Quak X1000 Ong Boon Leong
2014-09-26 4:30 ` [PATCH] x86, setup: add __flush_tlb() for Intel Quark X1000 Ong Boon Leong
2014-09-26 5:32 ` Dave Hansen
2014-09-26 8:44 ` Bryan O'Donoghue
2014-09-26 14:20 ` Dave Hansen
2014-09-26 14:30 ` Bryan O'Donoghue
2014-09-26 15:00 ` Bryan O'Donoghue
2014-09-26 17:22 ` Bryan O'Donoghue
2014-09-26 8:54 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542529AF.3050601@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=boon.leong.ong@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome