mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Fleming <matt@console-pimps.org>
To: Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, Mark Salter <msalter@redhat.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matt Fleming <matt.fleming@intel.com>,
	Dave Young <dyoung@redhat.com>
Subject: [PATCH] rtc: Disable EFI rtc for x86
Date: Fri,  3 Oct 2014 13:32:56 +0100	[thread overview]
Message-ID: <1412339576-17972-1-git-send-email-matt@console-pimps.org> (raw)

From: Matt Fleming <matt.fleming@intel.com>

commit da167ad7638759 ("rtc: ia64: allow other architectures to use EFI
RTC") inadvertently introduced a regression for x86. We've been careful
not to enable the EFI rtc driver for x86 due to the generally buggy
implementations of the time-related EFI runtime services.

Previous attempts have been made to us the time EFI services, but all
have eventually been reverted due to crashes inside the firmware code.

In fact, since the above commit was merged we've seen reports of crashes
on 32-bit tablets,

  https://bugzilla.kernel.org/show_bug.cgi?id=84241#c21

Disable it explicitly for x86 so that we don't give users false hope
that this driver will work - it won't, and your machine is likely to
crash.

Cc: Mark Salter <msalter@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
---

Unless anyone objects, I'm happy to take this through the EFI tree.

 drivers/rtc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index a168e96142b9..54ef393b0def 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -806,7 +806,7 @@ config RTC_DRV_DA9063
 
 config RTC_DRV_EFI
 	tristate "EFI RTC"
-	depends on EFI
+	depends on EFI && !X86
 	help
 	  If you say yes here you will get support for the EFI
 	  Real Time Clock.
-- 
1.9.3


             reply	other threads:[~2014-10-03 12:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 12:32 Matt Fleming [this message]
2014-10-03 15:01 ` Mark Salter
2014-11-09 17:37   ` Pali Rohár
2014-11-09 18:22     ` Borislav Petkov
2014-11-10 11:22       ` Matt Fleming
2014-11-10 16:23         ` Pali Rohár
2014-11-10 16:45           ` Austin S Hemmelgarn
2014-11-10 17:04             ` Matthew Garrett
2014-11-10 20:37               ` Austin S Hemmelgarn
2014-11-10 20:58                 ` H. Peter Anvin
2014-11-10 21:26                   ` Matthew Garrett
2014-11-11 11:38                   ` One Thousand Gnomes
2014-11-11 11:46                     ` Borislav Petkov
2014-11-11 11:53                     ` Pali Rohár
2014-11-11 12:14                     ` Austin S Hemmelgarn
2014-11-14 11:21             ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412339576-17972-1-git-send-email-matt@console-pimps.org \
    --to=matt@console-pimps.org \
    --cc=a.zummo@towertech.it \
    --cc=dyoung@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=msalter@redhat.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®