mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Fleming <matt.fleming@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
	"Mark Salter" <msalter@redhat.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Dave Young" <dyoung@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] rtc: Disable EFI rtc for x86
Date: Mon, 10 Nov 2014 11:22:13 +0000	[thread overview]
Message-ID: <1415618533.14686.239.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20141109182231.GA29337@pd.tnic>

On Sun, 2014-11-09 at 19:22 +0100, Borislav Petkov wrote:
> On Sun, Nov 09, 2014 at 06:37:46PM +0100, Pali Rohár wrote:
> > this patch totally disabled efi rfc driver on x86 machines at 
> > compile time. But on some x86 machines it working without crash 
> > and reading from file /sys/class/rtc/rtc*/since_epoch returns 
> > correct information. So why to disable compiling driver on 
> > machines where driver working?
> 
> Sounds like we need an efi=rtc_enable knob for people who what to use
> it...

I'm not so sure. By and large, the EFI runtime Time services just don't
work very well on x86. Just because they work sometimes, doesn't
actually mean it's a good idea to use them.

The one scenario where the time services are useful is early on during
boot when we want to get the timezone information. I have vague
recollections of someone working on that.


  reply	other threads:[~2014-11-10 11:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 12:32 Matt Fleming
2014-10-03 15:01 ` Mark Salter
2014-11-09 17:37   ` Pali Rohár
2014-11-09 18:22     ` Borislav Petkov
2014-11-10 11:22       ` Matt Fleming [this message]
2014-11-10 16:23         ` Pali Rohár
2014-11-10 16:45           ` Austin S Hemmelgarn
2014-11-10 17:04             ` Matthew Garrett
2014-11-10 20:37               ` Austin S Hemmelgarn
2014-11-10 20:58                 ` H. Peter Anvin
2014-11-10 21:26                   ` Matthew Garrett
2014-11-11 11:38                   ` One Thousand Gnomes
2014-11-11 11:46                     ` Borislav Petkov
2014-11-11 11:53                     ` Pali Rohár
2014-11-11 12:14                     ` Austin S Hemmelgarn
2014-11-14 11:21             ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415618533.14686.239.camel@mfleming-mobl1.ger.corp.intel.com \
    --to=matt.fleming@intel.com \
    --cc=a.zummo@towertech.it \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=msalter@redhat.com \
    --cc=pali.rohar@gmail.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®