From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jean Pihet <jean.pihet@linaro.org>
Subject: [PATCH 1/5] perf report: Set callchain_param.record_mode for future use
Date: Mon, 6 Oct 2014 09:45:59 +0900 [thread overview]
Message-ID: <1412556363-26229-2-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1412556363-26229-1-git-send-email-namhyung@kernel.org>
Normally the callchain_param.record_mode is used only for record path.
But as it might need to prepare something for dwarf unwinding, setup
this info for perf report too.
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jean Pihet <jean.pihet@linaro.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-report.c | 7 +++++++
tools/perf/tests/dwarf-unwind.c | 3 +++
tools/perf/util/callchain.h | 2 ++
tools/perf/util/hist.h | 2 --
4 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index ac145fae0521..f9a9ee7b2646 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -257,6 +257,13 @@ static int report__setup_sample_type(struct report *rep)
}
}
+ if (symbol_conf.use_callchain || symbol_conf.cumulate_callchain) {
+ if ((sample_type & PERF_SAMPLE_REGS_USER) &&
+ (sample_type & PERF_SAMPLE_STACK_USER))
+ callchain_param.record_mode = CALLCHAIN_DWARF;
+ else
+ callchain_param.record_mode = CALLCHAIN_FP;
+ }
return 0;
}
diff --git a/tools/perf/tests/dwarf-unwind.c b/tools/perf/tests/dwarf-unwind.c
index 96adb730b744..fc25e57f4a5d 100644
--- a/tools/perf/tests/dwarf-unwind.c
+++ b/tools/perf/tests/dwarf-unwind.c
@@ -9,6 +9,7 @@
#include "perf_regs.h"
#include "map.h"
#include "thread.h"
+#include "callchain.h"
static int mmap_handler(struct perf_tool *tool __maybe_unused,
union perf_event *event,
@@ -120,6 +121,8 @@ int test__dwarf_unwind(void)
return -1;
}
+ callchain_param.record_mode = CALLCHAIN_DWARF;
+
if (init_live_machine(machine)) {
pr_err("Could not init machine\n");
goto out;
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 2a1f5a46543a..94cfefddf4db 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -65,6 +65,8 @@ struct callchain_param {
enum chain_key key;
};
+extern struct callchain_param callchain_param;
+
struct callchain_list {
u64 ip;
struct map_symbol ms;
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index 8c9c70e18cbb..ac1ee82c6c7e 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -8,8 +8,6 @@
#include "color.h"
#include "ui/progress.h"
-extern struct callchain_param callchain_param;
-
struct hist_entry;
struct addr_location;
struct symbol;
--
2.1.0
next prev parent reply other threads:[~2014-10-06 0:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 0:45 [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4) Namhyung Kim
2014-10-06 0:45 ` Namhyung Kim [this message]
2014-10-16 5:23 ` [tip:perf/urgent] perf report: Set callchain_param.record_mode for future use tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 2/5] perf callchain: Create an address space per thread Namhyung Kim
2014-10-16 5:23 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 3/5] perf callchain: Use global caching provided by libunwind Namhyung Kim
2014-10-30 6:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 4/5] perf kvm: Use thread_{,_set}_priv helpers Namhyung Kim
2014-10-16 5:24 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 5/5] perf trace: " Namhyung Kim
2014-10-16 5:24 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-13 18:11 ` [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4) Jiri Olsa
2014-10-14 21:08 ` Arnaldo Carvalho de Melo
2014-10-15 19:24 ` Arnaldo Carvalho de Melo
2014-10-15 20:06 ` Arnaldo Carvalho de Melo
2014-10-16 13:14 ` Namhyung Kim
2014-10-22 1:34 ` Namhyung Kim
2014-10-22 1:50 ` Arnaldo Carvalho de Melo
2014-10-23 23:35 ` Arnaldo Carvalho de Melo
2014-10-24 0:44 ` Namhyung Kim
2014-10-24 1:56 ` Arnaldo Carvalho de Melo
2014-10-24 2:37 ` Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2014-10-02 3:08 [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v3) Namhyung Kim
2014-10-02 3:08 ` [PATCH 1/5] perf report: Set callchain_param.record_mode for future use Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412556363-26229-2-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®