From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)
Date: Fri, 24 Oct 2014 09:44:17 +0900 [thread overview]
Message-ID: <877fzqe1pa.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20141023233542.GR14687@kernel.org> (Arnaldo Carvalho de Melo's message of "Thu, 23 Oct 2014 20:35:42 -0300")
On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
>> Hi Arnaldo,
>>
>> On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
>> > Next time please run: (I'm fixing this up this time)
>> >
>> > [acme@zoo linux]$ time make -C tools/perf build-test
>> ...
>> > In file included from util/machine.c:14:0:
>> > util/unwind.h: In function ‘unwind__prepare_access’:
>> > util/unwind.h:47:57: error: unused parameter ‘thread’
>> > [-Werror=unused-parameter]
>> > static inline int unwind__prepare_access(struct thread *thread)
>> > ^
>> > util/unwind.h: In function ‘unwind__finish_access’:
>> > util/unwind.h:52:57: error: unused parameter ‘thread’
>> > [-Werror=unused-parameter]
>> > static inline void unwind__finish_access(struct thread *thread) {}
>> > ^
>> > cc1: all warnings being treated as errors
>> > make[3]: *** [util/machine.o] Error 1
>> > make[3]: *** Waiting for unfinished jobs....
>> > make[2]: *** [all] Error 2
>> > test: test -x ./perf
>> > make[1]: *** [make_no_libelf] Error 1
>> > make: *** [build-test] Error 2
>> > make: Leaving directory `/home/git/linux/tools/perf'
>>
>> So it seems you didn't include the patch 3/5 which is the key of this
>> series.. Could you please check it again?
>
> Yeah, I'm adding it now, and in this case as well the __maybe_unused was
> missing, added.
It was my bad to miss the annotation, sorry.
>
> I'll push later and will drop you a note, so that you can, please, check
> if the end result is sane.
Thank you!
> Sorry for the slip up,
No problem. :)
Thanks,
Namhyung
next prev parent reply other threads:[~2014-10-24 0:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 0:45 Namhyung Kim
2014-10-06 0:45 ` [PATCH 1/5] perf report: Set callchain_param.record_mode for future use Namhyung Kim
2014-10-16 5:23 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 2/5] perf callchain: Create an address space per thread Namhyung Kim
2014-10-16 5:23 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 3/5] perf callchain: Use global caching provided by libunwind Namhyung Kim
2014-10-30 6:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 4/5] perf kvm: Use thread_{,_set}_priv helpers Namhyung Kim
2014-10-16 5:24 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-06 0:46 ` [PATCH 5/5] perf trace: " Namhyung Kim
2014-10-16 5:24 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-13 18:11 ` [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4) Jiri Olsa
2014-10-14 21:08 ` Arnaldo Carvalho de Melo
2014-10-15 19:24 ` Arnaldo Carvalho de Melo
2014-10-15 20:06 ` Arnaldo Carvalho de Melo
2014-10-16 13:14 ` Namhyung Kim
2014-10-22 1:34 ` Namhyung Kim
2014-10-22 1:50 ` Arnaldo Carvalho de Melo
2014-10-23 23:35 ` Arnaldo Carvalho de Melo
2014-10-24 0:44 ` Namhyung Kim [this message]
2014-10-24 1:56 ` Arnaldo Carvalho de Melo
2014-10-24 2:37 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fzqe1pa.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome