From: Joe Perches <joe@perches.com>
To: Serguey Parkhomovsky <xindigo@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
florian.c.schilhabel@googlemail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c
Date: Wed, 08 Oct 2014 09:57:07 -0700 [thread overview]
Message-ID: <1412787427.3438.35.camel@joe-AO725> (raw)
In-Reply-To: <20141008034245.GA26853@fedora.localdomain>
On Tue, 2014-10-07 at 20:42 -0700, Serguey Parkhomovsky wrote:
> This patch fixes two unnecessary else conditions that were found by checkpatch.pl.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
[]
> @@ -541,15 +540,16 @@ u8 r8712_efuse_map_write(struct _adapter *padapter, u16 addr, u16 cnts,
[]
> +
> + if ((data[idx] != pktdata[i]) || (data[idx+1] !=
> + pktdata[i+1])) {
Just an fyi: (and I know you didn't introduce this)
Maximal fill to 80 columns is not always the most
readable for humans.
This sort of test is generally better where the
individual tests are written on separate lines like:
if ((data[idx] != pktdata[i]) ||
(data[idx+1] != pktdata[i+1])) {
next prev parent reply other threads:[~2014-10-08 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 3:42 Serguey Parkhomovsky
2014-10-08 16:57 ` Joe Perches [this message]
2014-10-08 8:12 ` Serguey Parkhomovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412787427.3438.35.camel@joe-AO725 \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xindigo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®