mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Serguey Parkhomovsky <xindigo@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
	florian.c.schilhabel@googlemail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c
Date: Wed, 8 Oct 2014 01:12:51 -0700	[thread overview]
Message-ID: <20141008081251.GA27404@fedora.localdomain> (raw)
In-Reply-To: <1412787427.3438.35.camel@joe-AO725>

> 
> This sort of test is generally better where the
> individual tests are written on separate lines like:
> 
> 			if ((data[idx] != pktdata[i]) ||
> 			    (data[idx+1] != pktdata[i+1])) {
> 

Thanks for all the suggestions, Joe. I'll upload a revised patch soon.

Serguey

      reply	other threads:[~2014-10-08 19:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  3:42 Serguey Parkhomovsky
2014-10-08 16:57 ` Joe Perches
2014-10-08  8:12   ` Serguey Parkhomovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141008081251.GA27404@fedora.localdomain \
    --to=xindigo@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®