[PATCH] char: misc: fix coding style issues

[PATCH] char: misc: fix coding style issues

[Rahul Bedarkar]

This patch fixes checkpatch.pl error
ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Rahul Bedarkar <rahulbedarkar89@gmail.com>
---
 drivers/char/misc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index a6b96b1..47c9b04 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -144,7 +144,7 @@ static int misc_open(struct inode *inode, struct file *file)
 	replace_fops(file, new_fops);
 	if (file->f_op->open) {
 		file->private_data = c;
-		err = file->f_op->open(inode,file);
+		err = file->f_op->open(inode, file);
 	}
 fail:
 	mutex_unlock(&misc_mtx);
@@ -279,7 +279,7 @@ static int __init misc_init(void)
 		goto fail_remove;
 
 	err = -EIO;
-	if (register_chrdev(MISC_MAJOR,"misc",&misc_fops))
+	if (register_chrdev(MISC_MAJOR, "misc", &misc_fops))
 		goto fail_pr_err;
 	misc_class->devnode = misc_devnode;
 	return 0;
-- 
1.8.3.2

Re: [PATCH] char: misc: Fix coding style issues

[Greg KH]

On Sat, Apr 11, 2026 at 03:30:46AM +0530, Shyam Sunder Reddy Padira wrote:
> Remove redundant filename from comment block and
> drop unnecessary braces for single statement block,
> as reported by changepatch.pl

There is no such tool :(

[PATCH] char: misc: Fix coding style issues

[Shyam Sunder Reddy Padira]

Remove redundant filename from comment block and
drop unnecessary braces for single statement block,
as reported by changepatch.pl

No functional changes

Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
 drivers/char/misc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 726516fb0a3b..8edce479223b 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * linux/drivers/char/misc.c
  *
  * Generic misc open routine by Johan Myreen
  *
@@ -255,9 +254,8 @@ int misc_register(struct miscdevice *misc)
 					  misc, misc->groups, "%s", misc->name);
 	if (IS_ERR(misc->this_device)) {
 		misc_minor_free(misc->minor);
-		if (is_dynamic) {
+		if (is_dynamic)
 			misc->minor = MISC_DYNAMIC_MINOR;
-		}
 		err = PTR_ERR(misc->this_device);
 		goto out;
 	}
-- 
2.43.0

[PATCH] char: misc: fix coding style issues

[Rahul Bedarkar]

This patch fixes checkpatch.pl error
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Rahul Bedarkar <rahulbedarkar89@gmail.com>
---
 drivers/char/misc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index ffa97d2..b4cf821 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -109,7 +109,7 @@ static const struct file_operations misc_proc_fops = {
 };
 #endif
 
-static int misc_open(struct inode * inode, struct file * file)
+static int misc_open(struct inode *inode, struct file *file)
 {
 	int minor = iminor(inode);
 	struct miscdevice *c;
@@ -175,7 +175,7 @@ static const struct file_operations misc_fops = {
  *	failure.
  */
  
-int misc_register(struct miscdevice * misc)
+int misc_register(struct miscdevice *misc)
 {
 	dev_t dev;
 	int err = 0;
-- 
1.8.3.2