From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Olof Johansson <olof@lixom.net>, Chris Zhong <zyw@rock-chips.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: [PATCH v3 1/5] regulator: of: Decrement refcount for suspend state nodes
Date: Mon, 20 Oct 2014 16:47:48 +0200 [thread overview]
Message-ID: <1413816472-1895-2-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1413816472-1895-1-git-send-email-javier.martinez@collabora.co.uk>
of_get_regulation_constraints() calls of_get_child_by_name() to find the
regulator-state-{mem,disk} child nodes for each regulator. This function
increments the device node reference counter but this is not decremented
once the function is done using the node.
Fix that by calling of_node_put() after finishing using the device node.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
drivers/regulator/of_regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index b375ffe..f0d19fc 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -107,6 +107,7 @@ static void of_get_regulation_constraints(struct device_node *np,
"regulator-off-in-suspend"))
suspend_state->disabled = true;
+ of_node_put(suspend_np);
suspend_state = NULL;
suspend_np = NULL;
}
--
2.1.0
next prev parent reply other threads:[~2014-10-20 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 14:47 [PATCH v3 0/5] Add max77802 regulator operating mode support Javier Martinez Canillas
2014-10-20 14:47 ` Javier Martinez Canillas [this message]
2014-10-22 16:38 ` [PATCH v3 1/5] regulator: of: Decrement refcount for suspend state nodes Mark Brown
2014-10-20 14:47 ` [PATCH v3 2/5] regulator: core: Add regulator mode and initial mode properties Javier Martinez Canillas
2014-10-20 14:47 ` [PATCH v3 3/5] regulator: max77802: Document regulator operating modes Javier Martinez Canillas
2014-10-20 14:47 ` [PATCH v3 4/5] regulator: max77802: Parse regulator operating mode properties Javier Martinez Canillas
2014-10-22 16:48 ` Mark Brown
2014-10-23 9:28 ` Javier Martinez Canillas
2014-10-24 21:02 ` Mark Brown
2014-10-26 23:24 ` Javier Martinez Canillas
2014-10-20 14:47 ` [PATCH v3 5/5] ARM: dts: Configure regulators for suspend on exynos Peach boards Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413816472-1895-2-git-send-email-javier.martinez@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®