mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frans Klaver <fransklaver@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Frans Klaver <fransklaver@gmail.com>,
	Corentin Chary <corentin.chary@gmail.com>,
	acpi4asus-user@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 6/8] eeepc-laptop: replace magic numbers with defines
Date: Wed, 22 Oct 2014 21:12:41 +0200	[thread overview]
Message-ID: <1414005163-3461-7-git-send-email-fransklaver@gmail.com> (raw)
In-Reply-To: <1414005163-3461-1-git-send-email-fransklaver@gmail.com>

eeepc_[gs]et_fan_ctrl uses some magic numbers. These numbers mean
something more than just the number. Describe them with macros instead
of comments in one of the functions.

Signed-off-by: Frans Klaver <fransklaver@gmail.com>
---
 drivers/platform/x86/eeepc-laptop.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index 21ffe1f..f820bb3 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -999,15 +999,19 @@ static int eeepc_get_fan_rpm(void)
 	return high << 8 | low;
 }
 
+#define EEEPC_EC_FAN_CTRL_BIT	0x02
+#define EEEPC_FAN_CTRL_MANUAL	1
+#define EEEPC_FAN_CTRL_AUTO	2
+
 static int eeepc_get_fan_ctrl(void)
 {
 	u8 value = 0;
 
 	ec_read(EEEPC_EC_FAN_CTRL, &value);
-	if (value & 0x02)
-		return 1; /* manual */
+	if (value & EEEPC_EC_FAN_CTRL_BIT)
+		return EEEPC_FAN_CTRL_MANUAL;
 	else
-		return 2; /* automatic */
+		return EEEPC_FAN_CTRL_AUTO;
 }
 
 static void eeepc_set_fan_ctrl(int manual)
@@ -1015,10 +1019,10 @@ static void eeepc_set_fan_ctrl(int manual)
 	u8 value = 0;
 
 	ec_read(EEEPC_EC_FAN_CTRL, &value);
-	if (manual == 1)
-		value |= 0x02;
+	if (manual == EEEPC_FAN_CTRL_MANUAL)
+		value |= EEEPC_EC_FAN_CTRL_BIT;
 	else
-		value &= ~0x02;
+		value &= ~EEEPC_EC_FAN_CTRL_BIT;
 	ec_write(EEEPC_EC_FAN_CTRL, value);
 }
 
-- 
2.1.0


  parent reply	other threads:[~2014-10-22 19:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 19:12 [PATCH 0/8] More eeepc-laptop cleanup Frans Klaver
2014-10-22 19:12 ` [PATCH 1/8] eeepc-laptop: flatten control flow Frans Klaver
2014-10-28  4:56   ` Darren Hart
2014-10-22 19:12 ` [PATCH 2/8] eeepc-laptop: don't break user visible strings Frans Klaver
2014-10-22 19:12 ` [PATCH 3/8] eeepc-laptop: define rfkill notifier nodes only once Frans Klaver
2014-10-28  5:12   ` Darren Hart
2014-10-28  8:28     ` Frans Klaver
2014-10-22 19:12 ` [PATCH 4/8] eeepc-laptop: pull out eeepc_destroy_rfkill Frans Klaver
2014-10-28  5:19   ` Darren Hart
2014-10-28  8:16     ` Frans Klaver
2014-10-22 19:12 ` [PATCH 5/8] eeepc-laptop: clean up control flow in eeepc_acpi_notify Frans Klaver
2014-10-28  5:25   ` Darren Hart
2014-11-02 21:14     ` [PATCH v2] " Frans Klaver
2014-11-04  6:01       ` Darren Hart
2014-10-22 19:12 ` Frans Klaver [this message]
2014-10-22 19:12 ` [PATCH 7/8] eeepc-laptop: document fan_pwm conversions Frans Klaver
2014-10-28  5:31   ` Darren Hart
2014-10-28  8:21     ` Frans Klaver
2014-10-22 19:12 ` [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds Frans Klaver
2014-10-28  5:34   ` Darren Hart
2014-10-28  8:09     ` Frans Klaver
2014-10-30  0:54       ` Darren Hart
2014-10-28  5:35 ` [PATCH 0/8] More eeepc-laptop cleanup Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414005163-3461-7-git-send-email-fransklaver@gmail.com \
    --to=fransklaver@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®