mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frans Klaver <fransklaver@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Frans Klaver <fransklaver@gmail.com>,
	Corentin Chary <corentin.chary@gmail.com>,
	acpi4asus-user@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 7/8] eeepc-laptop: document fan_pwm conversions
Date: Wed, 22 Oct 2014 21:12:42 +0200	[thread overview]
Message-ID: <1414005163-3461-8-git-send-email-fransklaver@gmail.com> (raw)
In-Reply-To: <1414005163-3461-1-git-send-email-fransklaver@gmail.com>

eeepc_get_fan_pwm and eeepc_set_fan_pwm convert the PWM value read from
the fan to a range lmsensors understands. Unfortunately this is only
clear if you are familiar with how lmsensors handles duty cycles.

Introduce two conversion functions that document the goal of these
conversions.

Signed-off-by: Frans Klaver <fransklaver@gmail.com>
---
 drivers/platform/x86/eeepc-laptop.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index f820bb3..275a239 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -974,18 +974,28 @@ static struct platform_driver platform_driver = {
 #define EEEPC_EC_SFB0      0xD0
 #define EEEPC_EC_FAN_CTRL  (EEEPC_EC_SFB0 + 3) /* Byte containing SF25  */
 
+static inline int eeepc_pwm_to_lmsensors(int value)
+{
+	return value * 255 / 100;
+}
+
+static inline int eeepc_lmsensors_to_pwm(int value)
+{
+	value = clamp_val(value, 0, 255);
+	return value * 100 / 255;
+}
+
 static int eeepc_get_fan_pwm(void)
 {
 	u8 value = 0;
 
 	ec_read(EEEPC_EC_FAN_PWM, &value);
-	return value * 255 / 100;
+	return eeepc_pwm_to_lmsensors(value);
 }
 
 static void eeepc_set_fan_pwm(int value)
 {
-	value = clamp_val(value, 0, 255);
-	value = value * 100 / 255;
+	value = eeepc_lmsensors_to_pwm(value);
 	ec_write(EEEPC_EC_FAN_PWM, value);
 }
 
-- 
2.1.0


  parent reply	other threads:[~2014-10-22 19:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 19:12 [PATCH 0/8] More eeepc-laptop cleanup Frans Klaver
2014-10-22 19:12 ` [PATCH 1/8] eeepc-laptop: flatten control flow Frans Klaver
2014-10-28  4:56   ` Darren Hart
2014-10-22 19:12 ` [PATCH 2/8] eeepc-laptop: don't break user visible strings Frans Klaver
2014-10-22 19:12 ` [PATCH 3/8] eeepc-laptop: define rfkill notifier nodes only once Frans Klaver
2014-10-28  5:12   ` Darren Hart
2014-10-28  8:28     ` Frans Klaver
2014-10-22 19:12 ` [PATCH 4/8] eeepc-laptop: pull out eeepc_destroy_rfkill Frans Klaver
2014-10-28  5:19   ` Darren Hart
2014-10-28  8:16     ` Frans Klaver
2014-10-22 19:12 ` [PATCH 5/8] eeepc-laptop: clean up control flow in eeepc_acpi_notify Frans Klaver
2014-10-28  5:25   ` Darren Hart
2014-11-02 21:14     ` [PATCH v2] " Frans Klaver
2014-11-04  6:01       ` Darren Hart
2014-10-22 19:12 ` [PATCH 6/8] eeepc-laptop: replace magic numbers with defines Frans Klaver
2014-10-22 19:12 ` Frans Klaver [this message]
2014-10-28  5:31   ` [PATCH 7/8] eeepc-laptop: document fan_pwm conversions Darren Hart
2014-10-28  8:21     ` Frans Klaver
2014-10-22 19:12 ` [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds Frans Klaver
2014-10-28  5:34   ` Darren Hart
2014-10-28  8:09     ` Frans Klaver
2014-10-30  0:54       ` Darren Hart
2014-10-28  5:35 ` [PATCH 0/8] More eeepc-laptop cleanup Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414005163-3461-8-git-send-email-fransklaver@gmail.com \
    --to=fransklaver@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®