mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: torvalds@linux-foundation.org, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	benh@kernel.crashing.org, Will Deacon <will.deacon@arm.com>
Subject: [RFC PATCH 1/2] zap_pte_range: update addr when forcing flush after TLB batching faiure
Date: Tue, 28 Oct 2014 11:44:21 +0000	[thread overview]
Message-ID: <1414496662-25202-2-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1414496662-25202-1-git-send-email-will.deacon@arm.com>

When unmapping a range of pages in zap_pte_range, the page being
unmapped is added to an mmu_gather_batch structure for asynchronous
freeing. If we run out of space in the batch structure before the range
has been completely unmapped, then we break out of the loop, force a
TLB flush and free the pages that we have batched so far. If there are
further pages to unmap, then we resume the loop where we left off.

Unfortunately, we forget to update addr when we break out of the loop,
which causes us to truncate the range being invalidated as the end
address is exclusive. When we re-enter the loop at the same address, the
page has already been freed and the pte_present test will fail, meaning
that we do not reconsider the address for invalidation.

This patch fixes the problem by incrementing addr by the PAGE_SIZE
before breaking out of the loop on batch failure.

Signed-off-by: Will Deacon <will.deacon@arm.com>
---
 mm/memory.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/memory.c b/mm/memory.c
index 1cc6bfbd872e..3e503831e042 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1147,6 +1147,7 @@ again:
 				print_bad_pte(vma, addr, ptent, page);
 			if (unlikely(!__tlb_remove_page(tlb, page))) {
 				force_flush = 1;
+				addr += PAGE_SIZE;
 				break;
 			}
 			continue;
-- 
2.1.1


  reply	other threads:[~2014-10-28 11:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 11:44 [RFC PATCH 0/2] Fix a couple of issues with zap_pte_range and MMU gather Will Deacon
2014-10-28 11:44 ` Will Deacon [this message]
2014-10-28 15:30   ` [RFC PATCH 1/2] zap_pte_range: update addr when forcing flush after TLB batching faiure Linus Torvalds
2014-10-28 16:07     ` Will Deacon
2014-10-28 16:25       ` Linus Torvalds
2014-10-28 17:07         ` Will Deacon
2014-10-28 18:03           ` Linus Torvalds
2014-10-28 21:16         ` Benjamin Herrenschmidt
2014-10-28 21:32           ` Linus Torvalds
2014-10-28 21:40     ` Linus Torvalds
2014-10-29 19:47       ` Will Deacon
2014-10-29 21:11         ` Linus Torvalds
2014-10-29 21:27           ` Benjamin Herrenschmidt
2014-11-01 17:01             ` Linus Torvalds
2014-11-01 20:25               ` Benjamin Herrenschmidt
2014-11-03 17:56               ` Will Deacon
2014-11-03 18:05                 ` Linus Torvalds
2014-11-04 14:29         ` Catalin Marinas
2014-11-04 16:08           ` Linus Torvalds
2014-11-06 13:57             ` Catalin Marinas
2014-11-06 17:53               ` Linus Torvalds
2014-11-06 18:38                 ` Catalin Marinas
2014-11-06 21:29                   ` Linus Torvalds
2014-11-07 16:50                     ` Catalin Marinas
2014-11-10 13:56                       ` Will Deacon
2014-10-28 11:44 ` [RFC PATCH 2/2] zap_pte_range: fix partial TLB flushing in response to a dirty pte Will Deacon
2014-10-28 15:18   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414496662-25202-2-git-send-email-will.deacon@arm.com \
    --to=will.deacon@arm.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome