From: Shuah Khan <shuah@kernel.org>
To: Colin King <colin.king@canonical.com>,
Max Kellermann <max.kellermann@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Markus Elfring <elfring@users.sourceforge.net>,
Hans Verkuil <hans.verkuil@cisco.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-media@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] [media] dvb_frontend: ensure that front end status is initialized
Date: Thu, 20 Jul 2017 09:48:27 -0600 [thread overview]
Message-ID: <141477a2-1435-b74a-3ee9-1eeb6765dc12@kernel.org> (raw)
In-Reply-To: <20170720152916.24266-1-colin.king@canonical.com>
Hi Colin,
On 07/20/2017 09:29 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The fe_status variable s is not initialized meaning it can have any
> random garbage status. This could be problematic if fe->ops.tune is
> false as s is not updated by the call to fe->ops.tune() and a
> subsequent check on the change status will using a garbage value.
> Fix this by initializing s to zero.
>
> Detected by CoverityScan, CID#112887 ("Uninitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/dvb-core/dvb_frontend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
> index e3fff8f64d37..e18ea1508a59 100644
> --- a/drivers/media/dvb-core/dvb_frontend.c
> +++ b/drivers/media/dvb-core/dvb_frontend.c
> @@ -631,7 +631,7 @@ static int dvb_frontend_thread(void *data)
> struct dvb_frontend *fe = data;
> struct dtv_frontend_properties *c = &fe->dtv_property_cache;
> struct dvb_frontend_private *fepriv = fe->frontend_priv;
> - enum fe_status s;
> + enum fe_status s = 0;
0 isn't a valid value for enum fe_status. I think the right fix would be
to add FE_NONE to enum fe_status and then initialize s to that.
thanks,
-- Shuah
> enum dvbfe_algo algo;
> bool re_tune = false;
> bool semheld = false;
>
prev parent reply other threads:[~2017-07-20 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 15:29 Colin King
2017-07-20 15:48 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141477a2-1435-b74a-3ee9-1eeb6765dc12@kernel.org \
--to=shuah@kernel.org \
--cc=colin.king@canonical.com \
--cc=elfring@users.sourceforge.net \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkh@osg.samsung.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®