From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 3/8] perf tools: Get rid of unused dsos__hit_all()
Date: Mon, 3 Nov 2014 16:27:53 +0900 [thread overview]
Message-ID: <1414999678-31377-4-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1414999678-31377-1-git-send-email-namhyung@kernel.org>
The dsos__hit_all() and its friends are not used anywhere. Let's get
rid of them.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
| 41 -----------------------------------------
| 2 --
2 files changed, 43 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 0ecf4a304cbc..e7c762f54bee 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -200,47 +200,6 @@ static int write_buildid(const char *name, size_t name_len, u8 *build_id,
return write_padded(fd, name, name_len + 1, len);
}
-static int __dsos__hit_all(struct list_head *head)
-{
- struct dso *pos;
-
- list_for_each_entry(pos, head, node)
- pos->hit = true;
-
- return 0;
-}
-
-static int machine__hit_all_dsos(struct machine *machine)
-{
- int err;
-
- err = __dsos__hit_all(&machine->kernel_dsos.head);
- if (err)
- return err;
-
- return __dsos__hit_all(&machine->user_dsos.head);
-}
-
-int dsos__hit_all(struct perf_session *session)
-{
- struct rb_node *nd;
- int err;
-
- err = machine__hit_all_dsos(&session->machines.host);
- if (err)
- return err;
-
- for (nd = rb_first(&session->machines.guests); nd; nd = rb_next(nd)) {
- struct machine *pos = rb_entry(nd, struct machine, rb_node);
-
- err = machine__hit_all_dsos(pos);
- if (err)
- return err;
- }
-
- return 0;
-}
-
static int __dsos__write_buildid_table(struct list_head *head,
struct machine *machine,
pid_t pid, u16 misc, int fd)
--git a/tools/perf/util/header.h b/tools/perf/util/header.h
index 8f5cbaea64a5..d08cfe499404 100644
--- a/tools/perf/util/header.h
+++ b/tools/perf/util/header.h
@@ -151,8 +151,6 @@ int perf_event__process_build_id(struct perf_tool *tool,
struct perf_session *session);
bool is_perf_magic(u64 magic);
-int dsos__hit_all(struct perf_session *session);
-
/*
* arch specific callback
*/
--
2.1.2
next prev parent reply other threads:[~2014-11-03 7:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 7:27 [PATCHSET 0/8] perf tools: Fix build-id matching on vmlinux (v5) Namhyung Kim
2014-11-03 7:27 ` [PATCH 1/8] perf tools: Preparation for compressed kernel module support Namhyung Kim
2014-11-03 13:51 ` Jiri Olsa
2014-11-03 15:01 ` Namhyung Kim
2014-11-03 7:27 ` [PATCH 2/8] perf tools: Add gzip decompression support for kernel module Namhyung Kim
2014-11-03 13:54 ` Jiri Olsa
2014-11-03 15:02 ` Namhyung Kim
2014-11-03 7:27 ` Namhyung Kim [this message]
2014-11-03 7:35 ` [PATCH 3/8] perf tools: Get rid of unused dsos__hit_all() Adrian Hunter
2014-11-03 7:39 ` Namhyung Kim
2014-11-03 7:51 ` Adrian Hunter
2014-11-03 7:27 ` [PATCH 4/8] perf tools: Rename dsos__write_buildid_table() Namhyung Kim
2014-11-03 7:27 ` [PATCH 5/8] perf build-id: Move build-id related functions to util/build-id.c Namhyung Kim
2014-11-03 7:27 ` [PATCH 6/8] perf record: Do not save pathname in ./debug/.build-id directory for vmlinux Namhyung Kim
2014-11-03 7:27 ` [PATCH 7/8] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-11-03 7:27 ` [PATCH 8/8] perf tools: Make vmlinux short name more like kallsyms short name Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 1:14 [PATCHSET 0/8] perf tools: Fix build-id matching on vmlinux (v6) Namhyung Kim
2014-11-04 1:14 ` [PATCH 1/8] perf tools: Preparation for compressed kernel module support Namhyung Kim
2014-11-04 10:58 ` Jiri Olsa
2014-11-07 5:29 ` [tip:perf/core] perf symbols: " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 2/8] perf tools: Add gzip decompression support for kernel module Namhyung Kim
2014-11-04 11:00 ` Jiri Olsa
2014-11-04 13:42 ` Arnaldo Carvalho de Melo
2014-11-05 2:59 ` Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-11-04 14:15 ` [PATCH 2/8] " Arnaldo Carvalho de Melo
2014-11-05 3:04 ` Namhyung Kim
2014-11-04 1:14 ` [PATCH 3/8] perf tools: Rename dsos__write_buildid_table() Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] perf build-id: " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 4/8] perf build-id: Move build-id related functions to util/build-id.c Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 5/8] perf tools: Move disable_buildid_cache() " Namhyung Kim
2014-11-04 1:14 ` [PATCH 6/8] perf record: Do not save pathname in ./debug/.build-id directory for vmlinux Namhyung Kim
2014-11-04 13:29 ` Arnaldo Carvalho de Melo
2014-11-05 2:54 ` Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] perf record: Do not save pathname in ./debug/ .build-id " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 7/8] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-11-07 5:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 8/8] perf tools: Make vmlinux short name more like kallsyms short name Namhyung Kim
2014-11-07 5:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-09-22 8:04 [PATCH v4] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-09-24 7:33 ` Ingo Molnar
2014-09-29 4:45 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414999678-31377-4-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®