From: Adrian Hunter <adrian.hunter@intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 3/8] perf tools: Get rid of unused dsos__hit_all()
Date: Mon, 03 Nov 2014 09:51:03 +0200 [thread overview]
Message-ID: <545733E7.6010105@intel.com> (raw)
In-Reply-To: <CAM9d7cjfBXrd-8JxDAfG7OM7X_XxkojFnrxpbGVVUW_xwnwkbA@mail.gmail.com>
On 03/11/14 09:39, Namhyung Kim wrote:
> Hi Adrian,
>
> On Mon, Nov 3, 2014 at 4:35 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> On 03/11/14 09:27, Namhyung Kim wrote:
>>> The dsos__hit_all() and its friends are not used anywhere. Let's get
>>> rid of them.
>>
>> They were added for Intel PT preparation. Intel PT is still on its way,
>> so they are still needed. Note the commit was:
>>
>> commit 1f625b0b3dd641b74ba21640a1fea19a3dd893a2
>> Author: Adrian Hunter <adrian.hunter@intel.com>
>> Date: Tue Jul 22 16:17:23 2014 +0300
>>
>> perf tools: Add dsos__hit_all()
>>
>> Add ability to mark all dsos as hit.
>>
>> This is needed in the case of Instruction Tracing. It takes so long to
>> decode an Instruction Trace that it is not worth doing just to determine
>> which dsos are hit. A later patch takes this into use.
>
> Oops, didn't notice. Sorry for not checking the commit log. So how
> about moving it into util/build-id.c then?
OK by me.
next prev parent reply other threads:[~2014-11-03 7:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 7:27 [PATCHSET 0/8] perf tools: Fix build-id matching on vmlinux (v5) Namhyung Kim
2014-11-03 7:27 ` [PATCH 1/8] perf tools: Preparation for compressed kernel module support Namhyung Kim
2014-11-03 13:51 ` Jiri Olsa
2014-11-03 15:01 ` Namhyung Kim
2014-11-03 7:27 ` [PATCH 2/8] perf tools: Add gzip decompression support for kernel module Namhyung Kim
2014-11-03 13:54 ` Jiri Olsa
2014-11-03 15:02 ` Namhyung Kim
2014-11-03 7:27 ` [PATCH 3/8] perf tools: Get rid of unused dsos__hit_all() Namhyung Kim
2014-11-03 7:35 ` Adrian Hunter
2014-11-03 7:39 ` Namhyung Kim
2014-11-03 7:51 ` Adrian Hunter [this message]
2014-11-03 7:27 ` [PATCH 4/8] perf tools: Rename dsos__write_buildid_table() Namhyung Kim
2014-11-03 7:27 ` [PATCH 5/8] perf build-id: Move build-id related functions to util/build-id.c Namhyung Kim
2014-11-03 7:27 ` [PATCH 6/8] perf record: Do not save pathname in ./debug/.build-id directory for vmlinux Namhyung Kim
2014-11-03 7:27 ` [PATCH 7/8] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-11-03 7:27 ` [PATCH 8/8] perf tools: Make vmlinux short name more like kallsyms short name Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 1:14 [PATCHSET 0/8] perf tools: Fix build-id matching on vmlinux (v6) Namhyung Kim
2014-11-04 1:14 ` [PATCH 1/8] perf tools: Preparation for compressed kernel module support Namhyung Kim
2014-11-04 10:58 ` Jiri Olsa
2014-11-07 5:29 ` [tip:perf/core] perf symbols: " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 2/8] perf tools: Add gzip decompression support for kernel module Namhyung Kim
2014-11-04 11:00 ` Jiri Olsa
2014-11-04 13:42 ` Arnaldo Carvalho de Melo
2014-11-05 2:59 ` Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-11-04 14:15 ` [PATCH 2/8] " Arnaldo Carvalho de Melo
2014-11-05 3:04 ` Namhyung Kim
2014-11-04 1:14 ` [PATCH 3/8] perf tools: Rename dsos__write_buildid_table() Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] perf build-id: " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 4/8] perf build-id: Move build-id related functions to util/build-id.c Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 5/8] perf tools: Move disable_buildid_cache() " Namhyung Kim
2014-11-04 1:14 ` [PATCH 6/8] perf record: Do not save pathname in ./debug/.build-id directory for vmlinux Namhyung Kim
2014-11-04 13:29 ` Arnaldo Carvalho de Melo
2014-11-05 2:54 ` Namhyung Kim
2014-11-07 5:30 ` [tip:perf/core] perf record: Do not save pathname in ./debug/ .build-id " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 7/8] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-11-07 5:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-11-04 1:14 ` [PATCH 8/8] perf tools: Make vmlinux short name more like kallsyms short name Namhyung Kim
2014-11-07 5:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-09-22 8:04 [PATCH v4] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-09-24 7:33 ` Ingo Molnar
2014-09-29 4:45 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545733E7.6010105@intel.com \
--to=adrian.hunter@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome