From: HuKeping <hukeping@huawei.com>
To: <swarren@nvidia.com>, <ebiederm@xmission.com>,
<linux@arm.linux.org.uk>, <rmk+kernel@arm.linux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <sdu.liu@huawei.com>,
<wangnan0@huawei.com>, <peifeiyue@huawei.com>
Subject: [RESEND PATCH] ARM: kexec: Fix validating CPU hotplug support
Date: Tue, 4 Nov 2014 17:40:25 +0800 [thread overview]
Message-ID: <1415094025-66180-1-git-send-email-hukeping@huawei.com> (raw)
Commit 2103f6cba61a8b8bea3fc1b63661d830a2125e76 added a hotplug checking in
machine_kexec_prepare(), but it will lead a failure when loading the
crash-kernel in some cases.
Kexec utility can load the crash kernel by two ways:
1. kexec -l kernel-image
2. kexec -p kernel-image
In case #1, for rapid reboot, it's correct to do the hotplug checking things,
for it will shut down cpus in _cpu_down() later when command "kexec -e" be
sent, this routine needs the support of cpu hotplug.
In case #2, for use on panic, it's unnecessary to do the same thing, the whole
routing has no business with cpu shutting down. Check for cpu hot plug will
lead a failure to load the kernel.
Prior to this patch, if the first kernel is not support the CPU hotplug, when
a crash come, the kexec utility will not work.
Signed-off-by: Hu Keping <hukeping@huawei.com>
---
arch/arm/kernel/machine_kexec.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
index 8cf0996..7706c67 100644
--- a/arch/arm/kernel/machine_kexec.c
+++ b/arch/arm/kernel/machine_kexec.c
@@ -41,11 +41,16 @@ int machine_kexec_prepare(struct kimage *image)
int i, err;
/*
+ * For rapid reboot:
* Validate that if the current HW supports SMP, then the SW supports
* and implements CPU hotplug for the current HW. If not, we won't be
* able to kexec reliably, so fail the prepare operation.
+ *
+ * For use on panic:
+ * It is unnecessary to check the cpu hot plug.
*/
- if (num_possible_cpus() > 1 && !platform_can_cpu_hotplug())
+ if (image->type != KEXEC_TYPE_CRASH &&
+ (num_possible_cpus() > 1 && !platform_can_cpu_hotplug()))
return -EINVAL;
/*
--
1.8.5.5
next reply other threads:[~2014-11-04 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 9:40 HuKeping [this message]
2014-11-04 10:55 ` Russell King - ARM Linux
2014-11-05 10:57 ` Hu Keping
2014-11-05 11:08 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415094025-66180-1-git-send-email-hukeping@huawei.com \
--to=hukeping@huawei.com \
--cc=ebiederm@xmission.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=peifeiyue@huawei.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sdu.liu@huawei.com \
--cc=swarren@nvidia.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®