From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: HuKeping <hukeping@huawei.com>
Cc: swarren@nvidia.com, ebiederm@xmission.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sdu.liu@huawei.com,
wangnan0@huawei.com, peifeiyue@huawei.com
Subject: Re: [RESEND PATCH] ARM: kexec: Fix validating CPU hotplug support
Date: Tue, 4 Nov 2014 10:55:25 +0000 [thread overview]
Message-ID: <20141104105525.GE4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1415094025-66180-1-git-send-email-hukeping@huawei.com>
On Tue, Nov 04, 2014 at 05:40:25PM +0800, HuKeping wrote:
> Commit 2103f6cba61a8b8bea3fc1b63661d830a2125e76 added a hotplug checking in
> machine_kexec_prepare(), but it will lead a failure when loading the
> crash-kernel in some cases.
>
> Kexec utility can load the crash kernel by two ways:
> 1. kexec -l kernel-image
> 2. kexec -p kernel-image
>
> In case #1, for rapid reboot, it's correct to do the hotplug checking things,
> for it will shut down cpus in _cpu_down() later when command "kexec -e" be
> sent, this routine needs the support of cpu hotplug.
>
> In case #2, for use on panic, it's unnecessary to do the same thing, the whole
> routing has no business with cpu shutting down. Check for cpu hot plug will
> lead a failure to load the kernel.
So what happens to the other CPUs when you kexec into the new kernel,
possibly overwriting the instructions which those CPUs are executing?
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-11-04 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 9:40 HuKeping
2014-11-04 10:55 ` Russell King - ARM Linux [this message]
2014-11-05 10:57 ` Hu Keping
2014-11-05 11:08 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104105525.GE4042@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ebiederm@xmission.com \
--cc=hukeping@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peifeiyue@huawei.com \
--cc=sdu.liu@huawei.com \
--cc=swarren@nvidia.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®