From: Pranith Kumar <bobby.prani@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org (open list:PERFORMANCE EVENT...)
Cc: paulmck@linux.vnet.ibm.com
Subject: [PATCH 10/16] perf: Replace smp_read_barrier_depends() with lockless_dereference()
Date: Thu, 13 Nov 2014 14:24:16 -0500 [thread overview]
Message-ID: <1415906662-4576-11-git-send-email-bobby.prani@gmail.com> (raw)
In-Reply-To: <1415906662-4576-1-git-send-email-bobby.prani@gmail.com>
Recently lockless_dereference() was added which can be used in place of
hard-coding smp_read_barrier_depends(). The following PATCH makes the change.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
kernel/events/core.c | 3 +--
kernel/events/uprobes.c | 8 ++++----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index d59fdc0..9dd5920 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -3400,14 +3400,13 @@ static void perf_remove_from_owner(struct perf_event *event)
struct task_struct *owner;
rcu_read_lock();
- owner = ACCESS_ONCE(event->owner);
/*
* Matches the smp_wmb() in perf_event_exit_task(). If we observe
* !owner it means the list deletion is complete and we can indeed
* free this event, otherwise we need to serialize on
* owner->perf_event_mutex.
*/
- smp_read_barrier_depends();
+ owner = lockless_dereference(event->owner);
if (owner) {
/*
* Since delayed_put_task_struct() also drops the last
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 6158a64b..c070949 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1212,8 +1212,8 @@ static struct xol_area *get_xol_area(void)
if (!mm->uprobes_state.xol_area)
__create_xol_area(0);
- area = mm->uprobes_state.xol_area;
- smp_read_barrier_depends(); /* pairs with wmb in xol_add_vma() */
+ /* pairs with wmb in xol_add_vma() */
+ area = lockless_dereference(mm->uprobes_state.xol_area);
return area;
}
@@ -1507,8 +1507,8 @@ static unsigned long get_trampoline_vaddr(void)
struct xol_area *area;
unsigned long trampoline_vaddr = -1;
- area = current->mm->uprobes_state.xol_area;
- smp_read_barrier_depends();
+ area = lockless_dereference(current->mm->uprobes_state.xol_area);
+
if (area)
trampoline_vaddr = area->vaddr;
--
1.9.1
next prev parent reply other threads:[~2014-11-13 19:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 19:24 [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence() Pranith Kumar
2014-11-13 19:24 ` [PATCH 01/16] crypto: caam - Remove unnecessary smp_read_barrier_depends() Pranith Kumar
2014-11-13 20:10 ` Paul E. McKenney
[not found] ` <546527D0.9040806@gmail.com>
2014-11-14 0:58 ` Kim Phillips
2014-11-13 19:24 ` [PATCH 02/16] doc: memory-barriers.txt: Document use of lockless_dereference() Pranith Kumar
2014-11-13 20:11 ` Paul E. McKenney
2014-11-13 19:24 ` [PATCH 03/16] drivers: dma: Replace smp_read_barrier_depends() with lockless_dereference() Pranith Kumar
2014-11-13 19:24 ` [PATCH 04/16] dcache: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 05/16] overlayfs: " Pranith Kumar
2014-11-17 10:35 ` Miklos Szeredi
2014-11-13 19:24 ` [PATCH 06/16] assoc_array: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 07/16] hyperv: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 08/16] rcupdate: " Pranith Kumar
2014-11-18 17:16 ` Paul E. McKenney
2014-11-18 19:38 ` Pranith Kumar
2014-11-13 19:24 ` [PATCH 09/16] percpu: " Pranith Kumar
2014-11-14 13:14 ` Tejun Heo
2014-11-14 16:02 ` Pranith Kumar
2014-11-17 4:43 ` Paul E. McKenney
2014-11-13 19:24 ` Pranith Kumar [this message]
2014-11-13 19:24 ` [PATCH 11/16] seccomp: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 12/16] task_work: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 13/16] ksm: " Pranith Kumar
2014-11-30 22:34 ` Hugh Dickins
2014-11-13 19:24 ` [PATCH 14/16] slab: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 15/16] netfilter: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 16/16] rxrpc: " Pranith Kumar
2014-11-13 20:07 ` [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence() Paul E. McKenney
2014-11-13 20:11 ` [PATCH 06/16] assoc_array: Replace smp_read_barrier_depends() with lockless_dereference() David Howells
2014-11-13 20:17 ` [PATCH 16/16] rxrpc: " David Howells
2014-11-13 20:47 ` David Howells
2014-11-13 21:55 ` Pranith Kumar
2014-11-13 23:07 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415906662-4576-11-git-send-email-bobby.prani@gmail.com \
--to=bobby.prani@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome