From: Pranith Kumar <bobby.prani@gmail.com>
To: "Dan Williams" <dan.j.williams@intel.com>,
"Vinod Koul" <vinod.koul@intel.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Manuel Schölling" <manuel.schoelling@gmx.de>,
"Dave Jiang" <dave.jiang@intel.com>,
Rashika <rashika.kheria@gmail.com>,
dmaengine@vger.kernel.org (open list:DMA GENERIC OFFLO...),
linux-kernel@vger.kernel.org (open list)
Cc: paulmck@linux.vnet.ibm.com
Subject: [PATCH 03/16] drivers: dma: Replace smp_read_barrier_depends() with lockless_dereference()
Date: Thu, 13 Nov 2014 14:24:09 -0500 [thread overview]
Message-ID: <1415906662-4576-4-git-send-email-bobby.prani@gmail.com> (raw)
In-Reply-To: <1415906662-4576-1-git-send-email-bobby.prani@gmail.com>
Recently lockless_dereference() was added which can be used in place of
hard-coding smp_read_barrier_depends(). The following PATCH makes the change.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
drivers/dma/ioat/dma_v2.c | 3 +--
drivers/dma/ioat/dma_v3.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c
index 695483e..0f94d72 100644
--- a/drivers/dma/ioat/dma_v2.c
+++ b/drivers/dma/ioat/dma_v2.c
@@ -142,10 +142,9 @@ static void __cleanup(struct ioat2_dma_chan *ioat, dma_addr_t phys_complete)
active = ioat2_ring_active(ioat);
for (i = 0; i < active && !seen_current; i++) {
- smp_read_barrier_depends();
prefetch(ioat2_get_ring_ent(ioat, idx + i + 1));
desc = ioat2_get_ring_ent(ioat, idx + i);
- tx = &desc->txd;
+ tx = &lockless_dereference(desc)->txd;
dump_desc_dbg(ioat, desc);
if (tx->cookie) {
dma_descriptor_unmap(tx);
diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
index 895f869..cbd0537 100644
--- a/drivers/dma/ioat/dma_v3.c
+++ b/drivers/dma/ioat/dma_v3.c
@@ -389,7 +389,6 @@ static void __cleanup(struct ioat2_dma_chan *ioat, dma_addr_t phys_complete)
for (i = 0; i < active && !seen_current; i++) {
struct dma_async_tx_descriptor *tx;
- smp_read_barrier_depends();
prefetch(ioat2_get_ring_ent(ioat, idx + i + 1));
desc = ioat2_get_ring_ent(ioat, idx + i);
dump_desc_dbg(ioat, desc);
@@ -398,7 +397,7 @@ static void __cleanup(struct ioat2_dma_chan *ioat, dma_addr_t phys_complete)
if (device->cap & IOAT_CAP_DWBES)
desc_get_errstat(ioat, desc);
- tx = &desc->txd;
+ tx = &lockless_dereference(desc)->txd;
if (tx->cookie) {
dma_cookie_complete(tx);
dma_descriptor_unmap(tx);
--
1.9.1
next prev parent reply other threads:[~2014-11-13 19:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 19:24 [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence() Pranith Kumar
2014-11-13 19:24 ` [PATCH 01/16] crypto: caam - Remove unnecessary smp_read_barrier_depends() Pranith Kumar
2014-11-13 20:10 ` Paul E. McKenney
[not found] ` <546527D0.9040806@gmail.com>
2014-11-14 0:58 ` Kim Phillips
2014-11-13 19:24 ` [PATCH 02/16] doc: memory-barriers.txt: Document use of lockless_dereference() Pranith Kumar
2014-11-13 20:11 ` Paul E. McKenney
2014-11-13 19:24 ` Pranith Kumar [this message]
2014-11-13 19:24 ` [PATCH 04/16] dcache: Replace smp_read_barrier_depends() with lockless_dereference() Pranith Kumar
2014-11-13 19:24 ` [PATCH 05/16] overlayfs: " Pranith Kumar
2014-11-17 10:35 ` Miklos Szeredi
2014-11-13 19:24 ` [PATCH 06/16] assoc_array: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 07/16] hyperv: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 08/16] rcupdate: " Pranith Kumar
2014-11-18 17:16 ` Paul E. McKenney
2014-11-18 19:38 ` Pranith Kumar
2014-11-13 19:24 ` [PATCH 09/16] percpu: " Pranith Kumar
2014-11-14 13:14 ` Tejun Heo
2014-11-14 16:02 ` Pranith Kumar
2014-11-17 4:43 ` Paul E. McKenney
2014-11-13 19:24 ` [PATCH 10/16] perf: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 11/16] seccomp: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 12/16] task_work: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 13/16] ksm: " Pranith Kumar
2014-11-30 22:34 ` Hugh Dickins
2014-11-13 19:24 ` [PATCH 14/16] slab: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 15/16] netfilter: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 16/16] rxrpc: " Pranith Kumar
2014-11-13 20:07 ` [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence() Paul E. McKenney
2014-11-13 20:11 ` [PATCH 06/16] assoc_array: Replace smp_read_barrier_depends() with lockless_dereference() David Howells
2014-11-13 20:17 ` [PATCH 16/16] rxrpc: " David Howells
2014-11-13 20:47 ` David Howells
2014-11-13 21:55 ` Pranith Kumar
2014-11-13 23:07 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415906662-4576-4-git-send-email-bobby.prani@gmail.com \
--to=bobby.prani@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rashika.kheria@gmail.com \
--cc=tglx@linutronix.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome