From: byungchul.park@lge.com
To: rostedt@goodmis.org
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
seungho1.park@lge.com, jolsa@redhat.com,
Byungchul Park <byungchul.park@lge.com>
Subject: [PATCH v4 1/3] tracing, function_graph: fix micro seconds notation in comment
Date: Tue, 18 Nov 2014 14:57:24 +0900 [thread overview]
Message-ID: <1416290246-882-2-git-send-email-byungchul.park@lge.com> (raw)
In-Reply-To: <1416290246-882-1-git-send-email-byungchul.park@lge.com>
From: Byungchul Park <byungchul.park@lge.com>
Usually, "msecs" notation means milli-seconds, and "usecs" notation
means micro-seconds. Since the unit used in the code is micro-seconds,
the notation should be replaced from msecs to usecs.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
kernel/trace/trace_functions_graph.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index f0a0c98..cb33f46 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -759,19 +759,19 @@ trace_print_graph_duration(unsigned long long duration, struct trace_seq *s)
{
unsigned long nsecs_rem = do_div(duration, 1000);
/* log10(ULONG_MAX) + '\0' */
- char msecs_str[21];
+ char usecs_str[21];
char nsecs_str[5];
int ret, len;
int i;
- sprintf(msecs_str, "%lu", (unsigned long) duration);
+ sprintf(usecs_str, "%lu", (unsigned long) duration);
/* Print msecs */
- ret = trace_seq_printf(s, "%s", msecs_str);
+ ret = trace_seq_printf(s, "%s", usecs_str);
if (!ret)
return TRACE_TYPE_PARTIAL_LINE;
- len = strlen(msecs_str);
+ len = strlen(usecs_str);
/* Print nsecs (we don't want to exceed 7 numbers) */
if (len < 7) {
@@ -822,10 +822,10 @@ print_graph_duration(unsigned long long duration, struct trace_seq *s,
/* Signal a overhead of time execution to the output */
if (flags & TRACE_GRAPH_PRINT_OVERHEAD) {
- /* Duration exceeded 100 msecs */
+ /* Duration exceeded 100 usecs */
if (duration > 100000ULL)
ret = trace_seq_puts(s, "! ");
- /* Duration exceeded 10 msecs */
+ /* Duration exceeded 10 usecs */
else if (duration > 10000ULL)
ret = trace_seq_puts(s, "+ ");
}
--
1.7.9.5
next prev parent reply other threads:[~2014-11-18 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 5:57 [PATCH v4 0/3] tracing: signaling large duration and delay byungchul.park
2014-11-18 5:57 ` byungchul.park [this message]
2014-11-18 5:57 ` [PATCH v4 2/3] tracing, function_graph: add additional marks to signal very large function execution time byungchul.park
2014-11-18 5:57 ` [PATCH v4 3/3] tracing: add additional marks to signal very large delay byungchul.park
2014-11-19 18:35 ` Steven Rostedt
2014-11-20 0:18 ` Byungchul Park
2014-11-20 6:11 ` Namhyung Kim
2014-11-20 6:33 ` Byungchul Park
2014-11-20 13:50 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416290246-882-2-git-send-email-byungchul.park@lge.com \
--to=byungchul.park@lge.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=seungho1.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®