From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: byungchul.park@lge.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, seungho1.park@lge.com,
jolsa@redhat.com
Subject: Re: [PATCH v4 3/3] tracing: add additional marks to signal very large delay
Date: Thu, 20 Nov 2014 08:50:28 -0500 [thread overview]
Message-ID: <20141120085028.29efe8cf@gandalf.local.home> (raw)
In-Reply-To: <87egsypfjs.fsf@sejong.aot.lge.com>
On Thu, 20 Nov 2014 15:11:19 +0900
Namhyung Kim <namhyung@kernel.org> wrote:
> >> + '#' - greater than 1000 microsecond
> >> + '!' - greater than 100 microsecond
> >> + '+' - greater than 10 microsecond
>
> I've noticed that it's now changed from 1 msec to 10 msec. Is it okay?
Yeah, I didn't like the inconsistency between the two tracers, and not
only that, I found the 1 microsecond mark rather useless. 10 is a much
better value. I don't think people will complain about this API change.
-- Steve
prev parent reply other threads:[~2014-11-20 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 5:57 [PATCH v4 0/3] tracing: signaling large duration and delay byungchul.park
2014-11-18 5:57 ` [PATCH v4 1/3] tracing, function_graph: fix micro seconds notation in comment byungchul.park
2014-11-18 5:57 ` [PATCH v4 2/3] tracing, function_graph: add additional marks to signal very large function execution time byungchul.park
2014-11-18 5:57 ` [PATCH v4 3/3] tracing: add additional marks to signal very large delay byungchul.park
2014-11-19 18:35 ` Steven Rostedt
2014-11-20 0:18 ` Byungchul Park
2014-11-20 6:11 ` Namhyung Kim
2014-11-20 6:33 ` Byungchul Park
2014-11-20 13:50 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120085028.29efe8cf@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=byungchul.park@lge.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=seungho1.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®