* [PATCH] usbnet: rtl8150: remove unused variable
@ 2014-11-18 12:59 Sudip Mukherjee
2014-11-18 15:30 ` Petko Manolov
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2014-11-18 12:59 UTC (permalink / raw)
To: Petko Manolov; +Cc: Sudip Mukherjee, linux-usb, netdev, linux-kernel
we were just returning the initial value of res, instead now
we are returning the value directly.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/net/usb/rtl8150.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 6e87e57..d37b7dc 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -753,14 +753,13 @@ static int rtl8150_open(struct net_device *netdev)
static int rtl8150_close(struct net_device *netdev)
{
rtl8150_t *dev = netdev_priv(netdev);
- int res = 0;
netif_stop_queue(netdev);
if (!test_bit(RTL8150_UNPLUG, &dev->flags))
disable_net_traffic(dev);
unlink_all_urbs(dev);
- return res;
+ return 0;
}
static void rtl8150_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info)
--
1.8.1.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usbnet: rtl8150: remove unused variable
2014-11-18 12:59 [PATCH] usbnet: rtl8150: remove unused variable Sudip Mukherjee
@ 2014-11-18 15:30 ` Petko Manolov
0 siblings, 0 replies; 2+ messages in thread
From: Petko Manolov @ 2014-11-18 15:30 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-usb, netdev, linux-kernel
On 14-11-18 18:29:59, Sudip Mukherjee wrote:
> we were just returning the initial value of res, instead now
> we are returning the value directly.
Looks OK, but could you please fix the wording of the commit message to something like:
Remove unused variable.
This is a tiny patch and the code speaks for itself.
Petko
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/net/usb/rtl8150.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 6e87e57..d37b7dc 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -753,14 +753,13 @@ static int rtl8150_open(struct net_device *netdev)
> static int rtl8150_close(struct net_device *netdev)
> {
> rtl8150_t *dev = netdev_priv(netdev);
> - int res = 0;
>
> netif_stop_queue(netdev);
> if (!test_bit(RTL8150_UNPLUG, &dev->flags))
> disable_net_traffic(dev);
> unlink_all_urbs(dev);
>
> - return res;
> + return 0;
> }
>
> static void rtl8150_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info)
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-18 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-18 12:59 [PATCH] usbnet: rtl8150: remove unused variable Sudip Mukherjee
2014-11-18 15:30 ` Petko Manolov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®