mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sched: fix start hrtick for short schedule slices on UP
@ 2014-11-21  8:24 Wanpeng Li
  0 siblings, 0 replies; only message in thread
From: Wanpeng Li @ 2014-11-21  8:24 UTC (permalink / raw)
  To: Ingo Molnar, Peter Zijlstra
  Cc: Juri Lelli, Kirill Tkhai, linux-kernel, Wanpeng Li

Start hrtick for schedule slices shorter than 10000ns doesn't make any 
sense and can cause timer DoS.

The commit 177ef2a6315e ("sched/deadline: Fix a precision problem in 
the microseconds range") fixes the shorter slices issue for dl class. 
Both the UP and SMP sides of hrtick_start() will handle the shorter 
slices issue before the commit, however, the UP side of hrtick_start() 
doesn't handle shorter slides issue any more after the commit applied.

This patch fix it by making sure the scheduling slice won't be smaller 
than 10us in the UP side of hrtick_start() for fair and dl schedule 
class.

Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
---
 kernel/sched/core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d44d0c5..dbfcca6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -490,6 +490,11 @@ static __init void init_hrtick(void)
  */
 void hrtick_start(struct rq *rq, u64 delay)
 {
+	/*
+	 * Don't schedule slices shorter than 10000ns, that just
+	 * doesn't make sense. Rely on vruntime for fairness.
+	 */
+	delay = max_t(u64, delay, 10000LL);
 	__hrtimer_start_range_ns(&rq->hrtick_timer, ns_to_ktime(delay), 0,
 			HRTIMER_MODE_REL_PINNED, 0);
 }
-- 
1.9.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-11-21  8:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-21  8:24 [PATCH] sched: fix start hrtick for short schedule slices on UP Wanpeng Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®