* [PATCH] perf symbols: Consider the syms_ss in dso__load_sym
@ 2014-11-21 10:54 Steve Capper
0 siblings, 0 replies; only message in thread
From: Steve Capper @ 2014-11-21 10:54 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Zijlstra, will.deacon, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Steve Capper
In dso__load_sym we only try to load the .debug_frame section from the
runtime image. For distros, the debug symbols are generally in a
separate file.
As a result, running perf report on arm64 can give errors such as:
"$file with build id $id not found, continuing without symbols"
Even when the debug symbols have been correctly installed (and loaded
by perf).
This patch adds logic to dso__load_sym to query syms_ss for the
.debug_frame section if it can't be found in the elf file pointed to by
runtime_ss.
Signed-off-by: Steve Capper <steve.capper@linaro.org>
---
This patch is against 3.18-rc5.
---
tools/perf/util/symbol-elf.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index 1e23a5b..1336392 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -830,8 +830,11 @@ int dso__load_sym(struct dso *dso, struct map *map,
continue;
sec = elf_getscn(runtime_ss->elf, sym.st_shndx);
- if (!sec)
- goto out_elf_end;
+ if (!sec) {
+ sec = elf_getscn(syms_ss->elf, sym.st_shndx);
+ if (!sec)
+ goto out_elf_end;
+ }
gelf_getshdr(sec, &shdr);
--
1.9.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-11-21 10:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-21 10:54 [PATCH] perf symbols: Consider the syms_ss in dso__load_sym Steve Capper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®