mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pranith Kumar <bobby.prani@gmail.com>
To: "Vinod Koul" <vinod.koul@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Josh Triplett" <josh@joshtriplett.org>,
	Rashika <rashika.kheria@gmail.com>,
	dmaengine@vger.kernel.org (open list:DMA GENERIC OFFLO...),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2 2/9] drivers: dma: Replace smp_read_barrier_depends() with lockless_dereference()
Date: Fri, 21 Nov 2014 10:05:56 -0500	[thread overview]
Message-ID: <1416582363-20661-3-git-send-email-bobby.prani@gmail.com> (raw)
In-Reply-To: <1416582363-20661-1-git-send-email-bobby.prani@gmail.com>

Recently lockless_dereference() was added which can be used in place of
hard-coding smp_read_barrier_depends(). The following PATCH makes the change.

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
 drivers/dma/ioat/dma_v2.c | 3 +--
 drivers/dma/ioat/dma_v3.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c
index 695483e..0f94d72 100644
--- a/drivers/dma/ioat/dma_v2.c
+++ b/drivers/dma/ioat/dma_v2.c
@@ -142,10 +142,9 @@ static void __cleanup(struct ioat2_dma_chan *ioat, dma_addr_t phys_complete)
 
 	active = ioat2_ring_active(ioat);
 	for (i = 0; i < active && !seen_current; i++) {
-		smp_read_barrier_depends();
 		prefetch(ioat2_get_ring_ent(ioat, idx + i + 1));
 		desc = ioat2_get_ring_ent(ioat, idx + i);
-		tx = &desc->txd;
+		tx = &lockless_dereference(desc)->txd;
 		dump_desc_dbg(ioat, desc);
 		if (tx->cookie) {
 			dma_descriptor_unmap(tx);
diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
index 895f869..cbd0537 100644
--- a/drivers/dma/ioat/dma_v3.c
+++ b/drivers/dma/ioat/dma_v3.c
@@ -389,7 +389,6 @@ static void __cleanup(struct ioat2_dma_chan *ioat, dma_addr_t phys_complete)
 	for (i = 0; i < active && !seen_current; i++) {
 		struct dma_async_tx_descriptor *tx;
 
-		smp_read_barrier_depends();
 		prefetch(ioat2_get_ring_ent(ioat, idx + i + 1));
 		desc = ioat2_get_ring_ent(ioat, idx + i);
 		dump_desc_dbg(ioat, desc);
@@ -398,7 +397,7 @@ static void __cleanup(struct ioat2_dma_chan *ioat, dma_addr_t phys_complete)
 		if (device->cap & IOAT_CAP_DWBES)
 			desc_get_errstat(ioat, desc);
 
-		tx = &desc->txd;
+		tx = &lockless_dereference(desc)->txd;
 		if (tx->cookie) {
 			dma_cookie_complete(tx);
 			dma_descriptor_unmap(tx);
-- 
1.9.1


  parent reply	other threads:[~2014-11-21 15:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 15:05 [PATCH v2 0/9] Replace smp_read_barrier_depends() with lockless_derefrence() Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 1/9] doc: memory-barriers.txt: Document use of lockless_dereference() Pranith Kumar
2014-11-21 15:05 ` Pranith Kumar [this message]
2014-11-21 15:05 ` [PATCH v2 3/9] dcache: Replace smp_read_barrier_depends() with lockless_dereference() Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 4/9] hyperv: " Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 5/9] percpu: " Pranith Kumar
2014-11-22 14:37   ` Tejun Heo
2014-12-02 18:04   ` Tejun Heo
2014-11-21 15:06 ` [PATCH v2 6/9] perf: " Pranith Kumar
2014-11-21 15:06 ` [PATCH v2 7/9] seccomp: " Pranith Kumar
2014-11-21 16:33   ` Kees Cook
2014-11-21 16:36     ` Pranith Kumar
2014-11-21 15:06 ` [PATCH v2 8/9] task_work: " Pranith Kumar
2014-11-21 15:06 ` [PATCH v2 9/9] netfilter: " Pranith Kumar
2014-11-21 16:12   ` Eric Dumazet
2014-11-21 21:57     ` Pranith Kumar
2014-11-22  0:05       ` Eric Dumazet
2014-11-22  1:23         ` Pranith Kumar
2014-11-22  0:24       ` Andres Freund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416582363-20661-3-git-send-email-bobby.prani@gmail.com \
    --to=bobby.prani@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.schoelling@gmx.de \
    --cc=rashika.kheria@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®