mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pranith Kumar <bobby.prani@gmail.com>
To: Kees Cook <keescook@chromium.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2 7/9] seccomp: Replace smp_read_barrier_depends() with lockless_dereference()
Date: Fri, 21 Nov 2014 10:06:01 -0500	[thread overview]
Message-ID: <1416582363-20661-8-git-send-email-bobby.prani@gmail.com> (raw)
In-Reply-To: <1416582363-20661-1-git-send-email-bobby.prani@gmail.com>

Recently lockless_dereference() was added which can be used in place of
hard-coding smp_read_barrier_depends(). The following PATCH makes the change.

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
 kernel/seccomp.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/seccomp.c b/kernel/seccomp.c
index 4ef9687..3729b06 100644
--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -175,17 +175,16 @@ static int seccomp_check_filter(struct sock_filter *filter, unsigned int flen)
  */
 static u32 seccomp_run_filters(struct seccomp_data *sd)
 {
-	struct seccomp_filter *f = ACCESS_ONCE(current->seccomp.filter);
 	struct seccomp_data sd_local;
 	u32 ret = SECCOMP_RET_ALLOW;
+	/* Make sure cross-thread synced filter points somewhere sane. */
+	struct seccomp_filter *f =
+			lockless_dereference(current->seccomp.filter);
 
 	/* Ensure unexpected behavior doesn't result in failing open. */
 	if (unlikely(WARN_ON(f == NULL)))
 		return SECCOMP_RET_KILL;
 
-	/* Make sure cross-thread synced filter points somewhere sane. */
-	smp_read_barrier_depends();
-
 	if (!sd) {
 		populate_seccomp_data(&sd_local);
 		sd = &sd_local;
-- 
1.9.1


  parent reply	other threads:[~2014-11-21 15:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 15:05 [PATCH v2 0/9] Replace smp_read_barrier_depends() with lockless_derefrence() Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 1/9] doc: memory-barriers.txt: Document use of lockless_dereference() Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 2/9] drivers: dma: Replace smp_read_barrier_depends() with lockless_dereference() Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 3/9] dcache: " Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 4/9] hyperv: " Pranith Kumar
2014-11-21 15:05 ` [PATCH v2 5/9] percpu: " Pranith Kumar
2014-11-22 14:37   ` Tejun Heo
2014-12-02 18:04   ` Tejun Heo
2014-11-21 15:06 ` [PATCH v2 6/9] perf: " Pranith Kumar
2014-11-21 15:06 ` Pranith Kumar [this message]
2014-11-21 16:33   ` [PATCH v2 7/9] seccomp: " Kees Cook
2014-11-21 16:36     ` Pranith Kumar
2014-11-21 15:06 ` [PATCH v2 8/9] task_work: " Pranith Kumar
2014-11-21 15:06 ` [PATCH v2 9/9] netfilter: " Pranith Kumar
2014-11-21 16:12   ` Eric Dumazet
2014-11-21 21:57     ` Pranith Kumar
2014-11-22  0:05       ` Eric Dumazet
2014-11-22  1:23         ` Pranith Kumar
2014-11-22  0:24       ` Andres Freund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416582363-20661-8-git-send-email-bobby.prani@gmail.com \
    --to=bobby.prani@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®