mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fixed type id
@ 2014-11-29 10:13 Ren Kimura
  2014-11-29 10:26 ` Richard Weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Ren Kimura @ 2014-11-29 10:13 UTC (permalink / raw)
  To: tglx; +Cc: linux-kernel, RKX1209

From: RKX1209 <rkx1209@gmail.com>

Signed-off-by: RKX1209 <rkx1209@gmail.com>
---
 arch/x86/mm/init_32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index c8140e1..957f7f0 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -304,14 +304,14 @@ repeat:
 #endif
 		for (; pmd_idx < PTRS_PER_PMD && pfn < end_pfn;
 		     pmd++, pmd_idx++) {
-			unsigned int addr = pfn * PAGE_SIZE + PAGE_OFFSET;
+			unsigned long addr = pfn * PAGE_SIZE + PAGE_OFFSET;
 
 			/*
 			 * Map with big pages if possible, otherwise
 			 * create normal page tables:
 			 */
 			if (use_pse) {
-				unsigned int addr2;
+				unsigned long addr2;
 				pgprot_t prot = PAGE_KERNEL_LARGE;
 				/*
 				 * first pass will use the same initial
-- 
1.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fixed type id
  2014-11-29 10:13 [PATCH] Fixed type id Ren Kimura
@ 2014-11-29 10:26 ` Richard Weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2014-11-29 10:26 UTC (permalink / raw)
  To: Ren Kimura; +Cc: Thomas Gleixner, LKML

On Sat, Nov 29, 2014 at 11:13 AM, Ren Kimura <rkx1209@gmail.com> wrote:
> From: RKX1209 <rkx1209@gmail.com>
>
> Signed-off-by: RKX1209 <rkx1209@gmail.com>

What issue does this fix?
On 32bit an address should fit into an integer.

> ---
>  arch/x86/mm/init_32.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index c8140e1..957f7f0 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -304,14 +304,14 @@ repeat:
>  #endif
>                 for (; pmd_idx < PTRS_PER_PMD && pfn < end_pfn;
>                      pmd++, pmd_idx++) {
> -                       unsigned int addr = pfn * PAGE_SIZE + PAGE_OFFSET;
> +                       unsigned long addr = pfn * PAGE_SIZE + PAGE_OFFSET;
>
>                         /*
>                          * Map with big pages if possible, otherwise
>                          * create normal page tables:
>                          */
>                         if (use_pse) {
> -                               unsigned int addr2;
> +                               unsigned long addr2;
>                                 pgprot_t prot = PAGE_KERNEL_LARGE;
>                                 /*
>                                  * first pass will use the same initial
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks,
//richard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-29 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-29 10:13 [PATCH] Fixed type id Ren Kimura
2014-11-29 10:26 ` Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®