RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

[Jeff Leung]

Does this mean that host-to guest timesync now works properly with Linux
guests?

-- Jeff

> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org
[mailto:linux-kernel-owner@vger.kernel.org]
> On Behalf Of K. Y. Srinivasan
> Sent: Tuesday, December 2, 2014 17:04
> To: x86@kernel.org; gregkh@linuxfoundation.org;
linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com; tglx@linutronix.de; hpa@zytor.com
> Cc: K. Y. Srinivasan; stable@vger.kernel.org
> Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
continuous
> 
> The clocksource based on Hyper-V per-partition reference count MSR is
continuous. Mark
> it accordingly.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> cc: stable@vger.kernel.org
> ---
>  arch/x86/kernel/cpu/mshyperv.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mshyperv.c
b/arch/x86/kernel/cpu/mshyperv.c index
> a450373..939155f 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
>  	.rating		= 400, /* use this when running on Hyperv*/
>  	.read		= read_hv_clock,
>  	.mask		= CLOCKSOURCE_MASK(64),
> +	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,
>  };
> 
>  static void __init ms_hyperv_init_platform(void)
> --
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in the body of a
> message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

[KY Srinivasan]

> -----Original Message-----
> From: Jeff Leung [mailto:jleung@v10networks.ca]
> Sent: Tuesday, December 2, 2014 3:58 PM
> To: KY Srinivasan; x86@kernel.org; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com; tglx@linutronix.de;
> hpa@zytor.com
> Cc: stable@vger.kernel.org
> Subject: RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
> continuous
> 
> Does this mean that host-to guest timesync now works properly with Linux
> guests?
> 
> -- Jeff

Jeff,

We have had the Hyper-V clocksource for sometime now and this patch just marks this clocksource
as being continuous. Nothing has changed with regards to timesynch.

Regards,

K. Y 

> 
> > -----Original Message-----
> > From: linux-kernel-owner@vger.kernel.org
> [mailto:linux-kernel-owner@vger.kernel.org]
> > On Behalf Of K. Y. Srinivasan
> > Sent: Tuesday, December 2, 2014 17:04
> > To: x86@kernel.org; gregkh@linuxfoundation.org;
> linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > jasowang@redhat.com; tglx@linutronix.de; hpa@zytor.com
> > Cc: K. Y. Srinivasan; stable@vger.kernel.org
> > Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
> continuous
> >
> > The clocksource based on Hyper-V per-partition reference count MSR is
> continuous. Mark
> > it accordingly.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > cc: stable@vger.kernel.org
> > ---
> >  arch/x86/kernel/cpu/mshyperv.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/mshyperv.c
> b/arch/x86/kernel/cpu/mshyperv.c index
> > a450373..939155f 100644
> > --- a/arch/x86/kernel/cpu/mshyperv.c
> > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
> >  	.rating		= 400, /* use this when running on Hyperv*/
> >  	.read		= read_hv_clock,
> >  	.mask		= CLOCKSOURCE_MASK(64),
> > +	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,
> >  };
> >
> >  static void __init ms_hyperv_init_platform(void)
> > --
> > 1.7.4.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a
> > message to majordomo@vger.kernel.org More majordomo info at
> > http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

[Jeff Leung]

> We have had the Hyper-V clocksource for sometime now and this patch
just marks this
> clocksource as being continuous. Nothing has changed with regards to
timesynch.

Alright, that cleared up that question. Gleaning around from the source
tree, I don't seem to 
comprehend what changes are being made when the clock source has the
flag 
CLOCK_SOURCE_IS_CONTINUOUS marked.

> Regards,
> 
> K. Y
> 
> >
> > > -----Original Message-----
> > > From: linux-kernel-owner@vger.kernel.org
> > [mailto:linux-kernel-owner@vger.kernel.org]
> > > On Behalf Of K. Y. Srinivasan
> > > Sent: Tuesday, December 2, 2014 17:04
> > > To: x86@kernel.org; gregkh@linuxfoundation.org;
> > linux-kernel@vger.kernel.org;
> > > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > > jasowang@redhat.com; tglx@linutronix.de; hpa@zytor.com
> > > Cc: K. Y. Srinivasan; stable@vger.kernel.org
> > > Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
> > continuous
> > >
> > > The clocksource based on Hyper-V per-partition reference count MSR
> > > is
> > continuous. Mark
> > > it accordingly.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > cc: stable@vger.kernel.org
> > > ---
> > >  arch/x86/kernel/cpu/mshyperv.c |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/x86/kernel/cpu/mshyperv.c
> > b/arch/x86/kernel/cpu/mshyperv.c index
> > > a450373..939155f 100644
> > > --- a/arch/x86/kernel/cpu/mshyperv.c
> > > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > > @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
> > >  	.rating		= 400, /* use this when running on Hyperv*/
> > >  	.read		= read_hv_clock,
> > >  	.mask		= CLOCKSOURCE_MASK(64),
> > > +	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,
> > >  };
> > >
> > >  static void __init ms_hyperv_init_platform(void)
> > > --
> > > 1.7.4.1
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in the body of a
> > > message to majordomo@vger.kernel.org More majordomo info at
> > > http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at  http://www.tux.org/lkml/
> 

[PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

[K. Y. Srinivasan]

The clocksource based on Hyper-V per-partition reference count MSR is
continuous. Mark it accordingly.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
cc: stable@vger.kernel.org
---
 arch/x86/kernel/cpu/mshyperv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index a450373..939155f 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
 	.rating		= 400, /* use this when running on Hyperv*/
 	.read		= read_hv_clock,
 	.mask		= CLOCKSOURCE_MASK(64),
+	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,
 };
 
 static void __init ms_hyperv_init_platform(void)
-- 
1.7.4.1

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

[KY Srinivasan]

> -----Original Message-----
> From: K. Y. Srinivasan [mailto:kys@microsoft.com]
> Sent: Tuesday, December 2, 2014 5:04 PM
> To: x86@kernel.org; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com; tglx@linutronix.de;
> hpa@zytor.com
> Cc: KY Srinivasan; stable@vger.kernel.org
> Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous
> 
> The clocksource based on Hyper-V per-partition reference count MSR is
> continuous. Mark it accordingly.

Thomas,

If there are no issues, please pickup this patch.

Regards,

K. Y
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> cc: stable@vger.kernel.org
> ---
>  arch/x86/kernel/cpu/mshyperv.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mshyperv.c
> b/arch/x86/kernel/cpu/mshyperv.c index a450373..939155f 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
>  	.rating		= 400, /* use this when running on Hyperv*/
>  	.read		= read_hv_clock,
>  	.mask		= CLOCKSOURCE_MASK(64),
> +	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,
>  };
> 
>  static void __init ms_hyperv_init_platform(void)
> --
> 1.7.4.1