* [PATCH v2] arm64: Enable CONFIG_COMPAT also for 64k page size
@ 2014-12-04 23:48 Alexander Graf
2014-12-04 23:49 ` Olof Johansson
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2014-12-04 23:48 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-arm-kernel, Will Deacon, Catalin Marinas, olof, lauraa
With binutils 2.25 the default alignment for 32bit arm sections changed to
have everything 64k aligned. Armv7 binaries built with this binutils version
run successfully on an arm64 system.
Since effectively there is now the chance to run armv7 code on arm64 even
with 64k page size, it doesn't make sense to block people from enabling
CONFIG_COMPAT on those configurations.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
v1 -> v2:
- add comment in KConfig explaining that segments need to be 64k aligned
- conditionalize the option on EXPERT
---
arch/arm64/Kconfig | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 9532f8d..7fc0ad6 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -409,7 +409,7 @@ source "fs/Kconfig.binfmt"
config COMPAT
bool "Kernel support for 32-bit EL0"
- depends on !ARM64_64K_PAGES
+ depends on !ARM64_64K_PAGES || EXPERT
select COMPAT_BINFMT_ELF
select HAVE_UID16
select OLD_SIGSUSPEND3
@@ -420,6 +420,10 @@ config COMPAT
the user helper functions, VFP support and the ptrace interface are
handled appropriately by the kernel.
+ If you also enabled CONFIG_ARM64_64K_PAGES, please be aware that you
+ will only be able to execute AArch32 binaries that were compiled with
+ 64k aligned segments.
+
If you want to execute 32-bit userspace applications, say Y.
config SYSVIPC_COMPAT
--
1.7.12.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: Enable CONFIG_COMPAT also for 64k page size
2014-12-04 23:48 [PATCH v2] arm64: Enable CONFIG_COMPAT also for 64k page size Alexander Graf
@ 2014-12-04 23:49 ` Olof Johansson
0 siblings, 0 replies; 2+ messages in thread
From: Olof Johansson @ 2014-12-04 23:49 UTC (permalink / raw)
To: Alexander Graf
Cc: linux-kernel, linux-arm-kernel, Will Deacon, Catalin Marinas,
Laura Abbott
On Thu, Dec 4, 2014 at 3:48 PM, Alexander Graf <agraf@suse.de> wrote:
> With binutils 2.25 the default alignment for 32bit arm sections changed to
> have everything 64k aligned. Armv7 binaries built with this binutils version
> run successfully on an arm64 system.
>
> Since effectively there is now the chance to run armv7 code on arm64 even
> with 64k page size, it doesn't make sense to block people from enabling
> CONFIG_COMPAT on those configurations.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Acked-by: Olof Johansson <olof@lixom.net>
-Olof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-04 23:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-04 23:48 [PATCH v2] arm64: Enable CONFIG_COMPAT also for 64k page size Alexander Graf
2014-12-04 23:49 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®